Project

General

Profile

Actions

Emulator Issues #1258

closed

Missing shading elements

Added by jayork42 over 14 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
GFX
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Some games, for example Sonic Riders, use special model shading not
currently supported by Dolphin. How difficult would it be to implement
these shadings? These look like simple texture maps, but correct me if I'm
wrong. Here's an image comparing Sonic Riders on the Gamecube to Dolphin.
The extra white shine is what I'm talking about. Sonic Heroes also uses
this shading technique but, like in SR, Dolphin doesn't draw the lighting.

Actions #1

Updated by jayork42 over 14 years ago

Oops, here's the image link. Sorry!

http://i28.tinypic.com/fy3gc1.png

Actions #2

Updated by marcus over 14 years ago

  • Status changed from New to Accepted
  • Issue type set to Bug
  • Priority set to Normal
  • Category set to gfx
  • Operating system N/A added
Actions #3

Updated by federelli over 14 years ago

Shadows seems to be missing as well!

Actions #4

Updated by jayork42 over 14 years ago

Also seems to be happening with Wii games. In the image Sonic looks slightly
shinier/darker, and not to mention the streaks on his glasses are missing.

http://i29.tinypic.com/2crrdon.png

Actions #5

Updated by jayork42 over 14 years ago

The SWG plugin in R4417 shows the shadows, but the shine still isn't there, in case
that help with anything.

Actions #6

Updated by j.rechards over 14 years ago

is this fixed by latest SVN ? i think so, or hope so hence the shading in NSMB is fixed
lately.

Actions #7

Updated by jayork42 over 14 years ago

The problem still exists in R4812.

Actions #8

Updated by Autoran1 about 14 years ago

These screens it's just upscaling, and no more differences

Actions #9

Updated by jayork42 about 14 years ago

What?

Actions #10

Updated by jayork42 about 14 years ago

By the way, in Sonic Heroes the characters on the Story and Challenge select screens
are fully shaded as normal. Does anyone have any idea how big of a deal this will be
to fix? Hopefully it will be something simple like the DX9 shading fix for NSMBW.

Actions #11

Updated by XTra.KrazzY over 13 years ago

did r6224 fix this?

Actions #12

Updated by jayork42 over 13 years ago

Unfortunately no. Sonic Heroes looks marginally better, but the shading commit doesn't fix the specular highlights. And strangely enough Sonic Riders actually looks worse with pixel shading on. The character models lose shading altogether.

http://i52.tinypic.com/2dhe8u0.png

Actions #13

Updated by donkopunchstania over 13 years ago

  • Status changed from Accepted to Fixed

This issue was closed by revision r6505.

Actions

Also available in: Atom PDF