Project

General

Profile

Actions

Emulator Issues #12633

closed

Crashes or Unknown Pointers with LLE Interpreter

Added by ZephyrSurfer over 3 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Current
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
5.0-14912
Fixed in:
5.0-14988

Description

Game Name?

N/A

Game ID? (right click the game in the game list, Properties, Info tab)

N/A

MD5 Hash? (right click the game in the game list, Properties, Verify tab, Verify Integrity button)

N/A

What's the problem? Describe what went wrong.

Playing any game will quickly produce unknown pointers or a crash to desktop when using DSP LLE Interpreter.

What steps will reproduce the problem?

Play any game with DSP LLE Interpreter set

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

5.0-14914

Is the issue present in the latest stable version?

No, 5.0

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

5.0-14912 -> https://dolphin-emu.org/download/dev/3aaab258109f7d1d373a020ccbd61a2d428aec79/

If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer

[Attach any fifologs if possible, write a description of fifologs and screenshots here to assist people unfamiliar with the game.]

What are your PC specifications? (CPU, GPU, Operating System, more)

i7-8750H
GTX 1060
Windows 10
8GB DDR4

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)

The commit that casues this issue is "DSPInterpreter: Fix sign extension of accumulators" (3b4bc9852fa19a66188ce2015ba8b1ab008dd9b3)


Related issues 1 (0 open1 closed)

Related to Emulator - Emulator Issues #12637: Update to DSP LLE breaks bios sound on startupFixed

Actions
Actions #1

Updated by JosJuice over 3 years ago

  • Milestone set to Current
  • Regression changed from No to Yes
  • Regression start set to 5.0-14912
Actions #2

Updated by pokechu22 over 3 years ago

  • Assignee set to pokechu22
Actions #3

Updated by pokechu22 over 3 years ago

  • Status changed from New to Fix pending

This is fixed in https://github.com/dolphin-emu/dolphin/pull/10045 (specifically https://github.com/dolphin-emu/dolphin/pull/10045/commits/4bbb6f244b8ba42f511c64598c33fdd4c4a6b6db). It's caused by direct loads to $acS.h sign-extending to 16 bits, resulting in the full accumulator being sign-extended from 40 to 48 bits. The fix is instead to sign-extend $acS.h to 32 bits, so that the full accumulator is sign-extended from 40 to 64 bits. Prior to 3b4bc9852fa19a66188ce2015ba8b1ab008dd9b3, the full accumulator was sign-extended from 40 to 64 bits on read, but I removed that as it seemed to be redundant without handling this part of the sign extension.

Actions #4

Updated by pokechu22 over 3 years ago

  • Status changed from Fix pending to Fixed
  • Fixed in set to 5.0-14988
Actions #5

Updated by pokechu22 over 3 years ago

Actions

Also available in: Atom PDF