Project

General

Profile

Emulator Issues #12735

Spyro A Hero's Tail Bloom not fully fixed by TEM cache

Added by khg8m3r 17 days ago. Updated 15 days ago.

Status:
New
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?

Spyro A Hero's Tail

Game ID? (right click the game in the game list, Properties, Info tab)

G5SE7D

MD5 Hash? (right click the game in the game list, Properties, Verify tab, Verify Integrity button)

dad9e57a1da344a7354a4b3276558eb1

What's the problem? Describe what went wrong.

The underwater fog/bloom, while still broken as per issue #9277 https://bugs.dolphin-emu.org/issues/9277, has some more issues after 5.0-15294 https://dolphin-emu.org/download/dev/master/5.0-15294/ pull request 8350 https://github.com/dolphin-emu/dolphin/pull/8350

This is a known regression by the devs on the pull request 8350 about the black bar underwater. If you turn off "Store EFB Copies to Texture Only" then the issue goes away. Turn off "Defer EFB Copies to RAM" first to prevent issues changing EFB2TEX <-> EFB2RAM.

.

However the lighting/bloom above water still has issues, if you turn off the "Store EFB Copies to Texture Only" the lighting/bloom problem is still broken on the fairy and other weird light sources (underwater glowing coral and certain background lights).

Also, setting the texture cache to "Fast" or "Medium" breaks the lighting even if "Store EFB Copies to Texture Only" is enabled. It only works properly if set to "Safe"

Renders correctly in Software Backend? The fog effect above ground looks more pixelated, but the lighting looks correct.

What steps will reproduce the problem?

Change settings to disable "Store EFB Copies to Texture Only" to Disabled, or set Texture Cache Accuracy to anything besides "Safe"
Load the game
See the light/bloom not correct on the fairy and skylight

Dive into the water to see the light/bloom not correct on the coral
Navigate around the black bar issue underwater (disable fog for easier navigation)

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes - 5.0-15476 still has the issue

Is the issue present in the latest stable version?

N/A due to other issue with Spyro and TEM

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

5.0-15294 - black bar issue introduced
5.0-15289 - No black bar present, but has lighting issue
5.0-4703 - Lighting issue goes as far back as previous TEM fix
5.0-4700 - Had broken TEM, so it had no underwater bloom issue, but broken lighting/bloom in a different way (coral lighting works with Accuracy set to "Fast" but not "Safe")

If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer

see attachments

What are your PC specifications? (CPU, GPU, Operating System, more)
Intel i5-6600
Nvidia GTX 1080 Ti
Windows 10 20H2
16GB RAM

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)

Save file attached

spyro_underwater_fog_issue_worse_small.dff (4.51 MB) spyro_underwater_fog_issue_worse_small.dff Underwater fifolog khg8m3r, 11/14/2021 09:18 PM
7D-G5SE-G5SE.gci (160 KB) 7D-G5SE-G5SE.gci Save File khg8m3r, 11/14/2021 09:21 PM
spyro_bloom_issue_2.zip (935 KB) spyro_bloom_issue_2.zip Above water bloom issue fifolog khg8m3r, 11/14/2021 09:47 PM
broken_lighting_fog_enabled_efb2ram.png (767 KB) broken_lighting_fog_enabled_efb2ram.png khg8m3r, 11/14/2021 11:14 PM
correct_lighting_fog_enabled_efb2tex.png (748 KB) correct_lighting_fog_enabled_efb2tex.png khg8m3r, 11/14/2021 11:14 PM
underwater_broken_lighting_fog_disabled_efb2ram.png (895 KB) underwater_broken_lighting_fog_disabled_efb2ram.png khg8m3r, 11/14/2021 11:14 PM
underwater_correct_lighting_fog_disabled_efb2tex.png (917 KB) underwater_correct_lighting_fog_disabled_efb2tex.png khg8m3r, 11/14/2021 11:14 PM
underwater_broken_lighting_fog_enabled_efb2ram.png (500 KB) underwater_broken_lighting_fog_enabled_efb2ram.png khg8m3r, 11/14/2021 11:14 PM
underwater_correct_lighting_fog_enabled_efb2tex.png (114 KB) underwater_correct_lighting_fog_enabled_efb2tex.png khg8m3r, 11/14/2021 11:14 PM
efb2vram_disabled_broken_lighting_broken_fog_color_banding.png (1.5 MB) efb2vram_disabled_broken_lighting_broken_fog_color_banding.png khg8m3r, 11/15/2021 12:30 AM
pr-10204_efb2vram_disabled__broken_lighting_correct_fog_color_banding.png (1.36 MB) pr-10204_efb2vram_disabled__broken_lighting_correct_fog_color_banding.png khg8m3r, 11/15/2021 12:30 AM
8727
8728
8729
8730
8731
8732
8733
8734

History

#1 Updated by khg8m3r 17 days ago

Black bar issues partially solved in efb2tex mode by https://github.com/dolphin-emu/dolphin/pull/10204
Lighting still broken when using efb2ram, but solves the underwater fog issue

#2 Updated by JMC4789 17 days ago

This is probably issues with Dolphin's EFB2Tex path more than anything.

#3 Updated by khg8m3r 17 days ago

Well the efb2tex path has correct lighting but the broken underwater fog (and black bar), where efb2ram has no black bar but broken lighting and broken underwater fog.
The PR fixes the efb2ram underwater fog issue but the lighting is still broken, and the efb2tex branch has a partially solved black bar issue and still underwater fog.

#4 Updated by JMC4789 17 days ago

Then it's probably more texture cache issues. Have you tried disabling EFB2VRAM in advanced?

#5 Updated by khg8m3r 17 days ago

8733
8734

It's behaving just like if efb2tex was disabled (running in efb2ram mode) but with color banding issues for both the latest master and the PR-10204 build.
The PR-10204 build also has two horizontal lines running through the screen.

#6 Updated by JMC4789 17 days ago

Color banding is probably just from force 24-bit or something. I don't think that's a bug.

#7 Updated by khg8m3r 17 days ago

Yes, it does look like when force 24-bit is disabled (running in 18-bit mode) for efb2tex and efb2ram, but more splotchy? I'm not sure what is more correct for this game, as it wasn't meant to run at such high resolutions, and I can't tell in software render mode in this area if it's supposed to look like that.

#8 Updated by JMC4789 16 days ago

Likely a few of the issues have to do with texture cache stuff, as Dolphin's Texture Cache is used as a way to "emulate" TMEM.

Getting this game to be perfect may require us to actually emulate TMEM properly. As long as it is playable for now, I don't think these regressions should count as a blocker for any potential release.

#9 Updated by Miksel12 16 days ago

Some things I noticed were that EFB with VRAM disabled gives horizontal lines, the same lines can be seen when disabling 'disable copy filter'. EFB to RAM (and texture) gives the same result as EFB to texture with medium and fast hashing except for the black bar which is now partially correct due to 5.0-15484. EFB to texture seems similair to the software renderer but I don't have the game so I don't know what is correct.

#10 Updated by phire 16 days ago

Horizontal lines are an unrelated regression from PR #10204. Spyro splits the rendering of its bloom up into horizontal slices so that they can fit inside a 640x80 pixel region of the EFB. Apparently dolphin doesn't do the correct thing when apply copy filter coefficients to the first and/or last line of these copies.

But for most of the frame, it's now more correct. There is more blur that wasn't being applied before, and some brightness adjustment.

I'm actually not sure which bloom is right. The one you get with efb2tex, or the one you get with "Disable EFB VRAM Copies". I suspect it's the latter.

#11 Updated by phire 15 days ago

The horizontal lines regression should be fixed with PR #10222

Also available in: Atom PDF