Project

General

Profile

Actions

Emulator Issues #12738

closed

Riivolution patch filenames are case sensitive, shouldn't be

Added by Meatball132 about 3 years ago. Updated almost 2 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-15520

Description

What's the problem? Describe what went wrong.

Riivolution on real hardware doesn't care about matching case, and will redirect to files even if they are not the same as on the disc (e.g. "message.arc" will replace "Message.arc"). On Dolphin, this does not occur; Message.arc does not get replaced because "message.arc" is capitalised differently.

What steps will reproduce the problem?

Example of a real-world mod in which this occurs is Newer Holiday Special (https://mega.nz/#!qnxXFQLC!O7JmvHEy2W-9mPQ7wt1VuCCHiOub1-8YpaNOyB-Rfew)

Custom text (message.arc in patch -> Message.arc on disc) and the Japanese title logo (OpeningTitle.arc in patch -> openingTitle.arc on disc) are loaded fine on real hardware, but Dolphin uses the files from the disc instead.

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes (5.0-15518)

Which is the first broken version?

This has been broken since Riivolution patch support was added in 5.0-15407

What are your PC specifications?

Windows 10 (Version 20H2, OS Build 19042.1348, 64-Bit)

Attached files

Screenshots of Newer Holiday Special's title screen as an example; the incorrect version is due to "openingTitle.arc" being incorrectly called "OpeningTitle.arc" in the Japanese patch, so the file does not get redirected. The correct version is what happens when the case matches exactly (openingTitle.arc -> openingTitle.arc), and is also the behaviour on hardware regardless of case.


Files

Actions #2

Updated by BhaaL almost 2 years ago

  • Status changed from New to Fixed

Meatball132 confirmed on Discord that this is fixed.

Actions #3

Updated by BhaaL almost 2 years ago

  • Fixed in set to 5.0-15520-g6ca2897d20
Actions #4

Updated by JosJuice almost 2 years ago

  • Fixed in changed from 5.0-15520-g6ca2897d20 to 5.0-15520
Actions

Also available in: Atom PDF