Project

General

Profile

Actions

Emulator Issues #12744

closed

Hotkeys Are Broken

Added by ZephyrSurfer over 2 years ago. Updated over 2 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Current
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
5.0-15561
Fixed in:
5.0-15590

Description

Game Name?

N/A

Game ID? (right click the game in the game list, Properties, Info tab)

N/A

MD5 Hash? (right click the game in the game list, Properties, Verify tab, Verify Integrity button)

N/A

What's the problem? Describe what went wrong.

Hotkeys stopped working. I've been trying the fullscreen shortcut.

What steps will reproduce the problem?

Play a game. Press ALT + ENTER

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes, 5.0-15568

Is the issue present in the latest stable version?

No, 5.0

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

5.0-15561

If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer

[Attach any fifologs if possible, write a description of fifologs and screenshots here to assist people unfamiliar with the game.]

What are your PC specifications? (CPU, GPU, Operating System, more)

i7-8750H
GTX 1060
Windows 10
8GB DDR4

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)

Let me know, I'll see what else I can do.


Files

GBA_5.0-15559.ini (358 Bytes) GBA_5.0-15559.ini Default 5.0-15559 Works ZephyrSurfer, 11/26/2021 08:09 PM
GBA_5.0-15561.ini (198 Bytes) GBA_5.0-15561.ini Default 5.0-15559 Broken ZephyrSurfer, 11/26/2021 08:10 PM
Actions #1

Updated by MayImilae over 2 years ago

  • Status changed from New to Invalid

Unable to reproduce in 5.0-15568. Please be sure to check for configuration issues before posting an issue report.

Actions #2

Updated by ZephyrSurfer over 2 years ago

Not only did I check for configuration issues I ran through and made a bisect which I have provided.

I can even reproduce this when I rename the global dolphin directory and download the latest development build and put it in portable mode.

It works in 5.0-15559

It is broken in 5.0-15561 -> https://dolphin-emu.org/download/dev/e1e3db13baabefa89991388d37db0bb260c4f535/

Actions #3

Updated by JosJuice over 2 years ago

  • Status changed from Invalid to New
  • Milestone set to Current
  • Regression changed from No to Yes
  • Regression start set to 5.0-15561

That bisect makes sense, so I'm willing to reopen this.

Updated by ZephyrSurfer over 2 years ago

I figured out what's breaking. This affects a lot more than hotkeys it also affects emulated Wii Remotes, GBA etc.

If a new user runs 5.0-15559 it will write correct configuration files.

If a new user runs 5.0-15561 or newer it will not write the "Device" line in the configuration files.

Actions #5

Updated by ZephyrSurfer over 2 years ago

Made a typo and wrote the same build on both uploaded file descriptions but the broken one is 5.0-15561 like I mentioned above.

Actions #6

Updated by filoppi over 2 years ago

I've been able to reproduce this, and it seems that indeed starting from 5.0-15561, the device lines are not written to the config files.
I will take a look at the code.

Actions #7

Updated by filoppi over 2 years ago

Try this PR please, it should fix it:
https://github.com/dolphin-emu/dolphin/pull/10248

Actions #8

Updated by ZephyrSurfer over 2 years ago

I've commented already on the PR but yeah this solves the issue. Tested on Windows 10.

Actions #9

Updated by JosJuice over 2 years ago

  • Status changed from New to Fixed
  • Fixed in set to 5.0-15590
Actions

Also available in: Atom PDF