Project

General

Profile

Actions

Emulator Issues #1277

closed

Crash on stop

Added by jayork42 over 14 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What steps will reproduce the problem?

  1. Start a game, Gamecube or Wii
  2. Once it loads, press Esc to quit
    3.

What is the expected output? What do you see instead?
Dolphin is expected to close the render window and return to the game
list. Instead it closes the window and crashes about 95% of the time.

What version of the product are you using? On what operating system?
SVN R 3958 x86 WinXP Pro

Please provide any additional information below.


Related issues 8 (0 open8 closed)

Has duplicate Emulator - Emulator Issues #1318: Segfault in Linux 64bit after Stop Button is pressed (libpthread)Duplicate

Actions
Has duplicate Emulator - Emulator Issues #1336: Crash when press "Esc"Duplicate

Actions
Has duplicate Emulator - Emulator Issues #1343: Dolphin always crash when press ESCDuplicate

Actions
Has duplicate Emulator - Emulator Issues #1796: Dolphin crashes!Duplicate

Actions
Has duplicate Emulator - Emulator Issues #2017: Pressing Stop crashes the emulator 8 times out of 10Duplicate

Actions
Has duplicate Emulator - Emulator Issues #2073: OpenGL usage crashes Dolphin on 2nd game loadDuplicate

Actions
Blocks Emulator - Emulator Issues #2043: Release bug trackerFixednakeee

Actions
Blocked by Emulator - Emulator Issues #2283: HLE+dsound causing the crashes when exitingFixed

Actions
Actions #1

Updated by jayork42 over 14 years ago

I just noticed that it doesn't crash after only 5 or so seconds of running the game.
It almost always happens after a normal play session of at least 10 minutes.

Actions #2

Updated by BhaaL over 14 years ago

I get such crashes randomly after stopping a game.
It either:

  • crashes when I close Dolphin (might be some sort of dtor bailing out)
  • crashes when starting another/the same game after this (only sometimes, with no
    appearent reason/indications)
  • crashes when I change windows, to for example the Webbrowser, and switch back to
    Dolphin after some time (that might be wx related, since it shouldn't be doing
    anything but drawing the GUI by that time).
Actions #3

Updated by marcus over 14 years ago

  • Status changed from New to Accepted
Actions #4

Updated by Anonymous over 14 years ago

for me it crashes all the time when stopping in single core mode. Dual core mode seems
fine.

Actions #5

Updated by sl1nk3.s over 14 years ago

really ? i thought i fixed the single core crashes :/
I'm also using WinXP x86 and stopping seems fine most of the time, however i
sometimes get an odd wxwidget crash when i stop a game :
It'll take like 2 or 3 seconds to stop the game instead of being almost instantaneous
and it'll crash as soon as I try to resize or move the window around, though i'm able
to double click the gamelist to start another game just fine if i don't try to move
or resize the window...

Actions #6

Updated by imant23 over 14 years ago

In dual core mode crashes too.

Unhandled Exception
Code: 0xC0000005
Call stack info:
0x047F13F0 : ?

Actions #7

Updated by Choate.Tim over 14 years ago

It's happend to me too. But if I save game and press ESC button after that, I can
close to the render window :D

Actions #8

Updated by sl1nk3.s over 14 years ago

Issue 1343 has been merged into this issue.

Actions #9

Updated by marcus over 14 years ago

Issue 1336 has been merged into this issue.

Actions #10

Updated by Wagnard28 over 14 years ago

For me, it seem to happen only with the OPENGL plugin.
When I use direct3d, I have'nt encounter this stop crash yet.

Actions #11

Updated by fabiode34 over 14 years ago

i don't r3emember in what revision... but the problem was gone... but in the latest
revision the problem was reappeared

Actions #12

Updated by BhaaL over 14 years ago

Possible fix for the OpenGL crash:
http://pastie.org/740223
I'm not exactly sure if we should keep it like that, or remove the overall "if
(s_PluginInitialized)"-Check altogether and just let it happen. Shutdown should take
care of the rest, shouldn't it?

The seemingly randomness of that one was due to the check performed, and possibly a
context switch right afterwards.
The DX9 Plugin should not have this issue, since the same piece of code is commented
out there, with a comment that it appearently works without YieldCPU.

Actions #13

Updated by BhaaL over 14 years ago

Video_AccessEFB might show the same issue with a bit of timing.

I'm not exactly sure how/when Common::AtomicLoadAcquire works or not, but since
Shutdown also sets the two flags that are waited on...why does it still block?

Actions #14

Updated by sl1nk3.s over 14 years ago

Issue 1796 has been merged into this issue.

Actions #15

Updated by ayuanx over 14 years ago

Now DX9 shutdown should be clean (as far as I've tested), but OpenGL shutdown is not.
I've got one clue is that if you pause the game first, before stopping the game, then
OpenGL shutdown is clean.

Actions #16

Updated by BhaaL over 14 years ago

I'm afraid it isnt. DebugFast x64 r4758 on Win7 x64, ATI Radeon HD5770, JIT, DC on.

  • DX9, Render-to-main false, Close render-window with "X": Main window responsive, no
    Gamelist, Rendering window hangs (and the only way is to kill Dolphin).
  • DX9, RTM false, Click "Stop" in main window: Works fine.
  • DX9, RTM true, Click "Stop" in main window: CPU wait returned: WAIT_OBJECT_0, 5
    seconds "hang", Emu wait returned: WAIT_TIMEOUT. Other than that, works fine.
  • OGL, RTM false, Close render-window with "X": Main window responsive, no Gamelist,
    Rendering window hangs (same as DX9).
  • OGL, RTM false, Click "Stop" in main window: Sometimes works fine, in random cases
    Emu wait returned: WAIT_TIMEOUT. Render window hangs, no Gamelist, etc. Mainly
    happens when starting the game and quickly clicking Stop (which is rather unlikely
    when using Dolphin as intended?)
  • OGL, RTM true, Click "Stop" in main window: Emu wait returned: WAIT_TIMEOUT. Partly
    responsive, but hangs soon after that.

The cases with RTM false and closing the render window, leaving it hanging while the
main window responds is usually accompanied by an access violation on the CPU/Main
Thread (inside JITted code).

I also noticed that DX9 RTM keeps the aspect ratio, while OGL does not. In a small
window, where the bottom part is the Log window, DX9 shows a correctly ratio'd game
(at very small size), while OGL fills the whole remaining space (ignoring aspect
ratio, stretching the image).

Actions #17

Updated by mlkbouba over 14 years ago

I had the same problem to stop my games
I try to find it
http://code.google.com/p/dolphin-emu/source/diff?spec=svn4803&r=4803&format=side&path=/trunk/Source/Core/Core/Src/Core.cpp
taken over the old code.
stop my game works has the normal
sorry for tradition

Actions #18

Updated by BhaaL over 14 years ago

r4860 might have fixed this, someone please verify it.

Actions #19

Updated by justin.sweglar over 14 years ago

OPENGL still crashes on any stop function.(Although I only have OPENGL 1.2 card) As
of r4861 it no longer crashes in full screen pressing ESC in DX. May be related to
Issue 1961(my issue) ESC has the same function as pressing stop. The new issue since
it doesn't crash is that the question box now appears behind the full screen. So you
can press ESC as much as you want and have a 100, do you want to stop emulation
question boxes. Only way to exit out is alt tab then press yes.

Actions #20

Updated by j.rechards over 14 years ago

DX9 still crashes on stop or ESC in JIT32Bit

Actions #21

Updated by Anonymous over 14 years ago

Issue 2017 has been merged into this issue.

Actions #22

Updated by skidau over 14 years ago

Issue 2073 has been merged into this issue.

Actions #23

Updated by justin.sweglar over 14 years ago

In dolphin.log, it seems like the sound causes the crashes.

This line can be seen plus a few extra after it closes correctly.

51:45:531 .\Src\PluginManager.cpp:204 N[CONSOLE]: Stop [Video Thread 2516] 112,852 K
Video shutdown
51:45:546
f:\emulation\gamecube\dolphin-emu\source\core\audiocommon\src\SoundStream.h:64
N[DSPHLE]: Stopping Audio logging

This is what shows up when it doesn't. The video shut down is the normal line above
the stopping audio logging/already stopped. When it fails it stops at Video shutdown
followed by a cannot find file(although im not sure if this part is caused by the
shutdown or restart, if its the shutdown then video could be the issue but the log
stats that the video is shutdown... and I think those are times on the left side)

01:31:125 .\Src\PluginManager.cpp:203 N[CONSOLE]: Stop [Video Thread 304] 87,468 K
Video shutdown
37:20:859 .\Src\FileUtil.cpp:92 W[COMMON]: IsDirectory: stat failed on
./User/Wii/title/00000001/00000002/content: The system cannot find the file specified.

37:20:968 .\Src\DynamicLibrary.cpp:159 W[COMMON]: DL: Symbol EmuStateChange missing
in Plugins/Plugin_OldVideoDX9.dll (error: The specified procedure could not be found.
)

37:20:968 .\Src\PluginManager.cpp:236 W[CONSOLE]: PluginInfo:
Plugins/Plugin_OldVideoDX9.dll is not a valid Dolphin plugin. Ignoring.

Actions #24

Updated by nakeee over 14 years ago

I didn't get a crash in a while now.
Anyone is against closing this bug?

Actions #25

Updated by ayuanx over 14 years ago

some random crash on stop still happeens even in r5000

Unhandled Exception
Code: 0xC0000005
Call stack info:
0x059D01D0 : ?
USER32!0x7E42B372 : MoveWindow
USER32!0x7E42B317 : MoveWindow
USER32!0x7E4278D0 : GetWindowTextLengthW
ntdll!0x7C90E453 : KiUserCallbackDispatcher
USER32!0x7E419402 : PeekMessageW
Dolphin!0x00549A36 : WxUtils::Explore
Dolphin!0x00703588 : _CItan_pentium4
Dolphin!0x005486B2 : WxUtils::Explore
Dolphin!0x004D2D5C : WxUtils::Explore
Dolphin!0x004AF514 : WxUtils::Explore
Dolphin!0x005490D8 : WxUtils::Explore
main.cpp(52) : WinMain
kernel32!0x7C817067 : RegisterWaitForInputIdle

Unhandled Exception
Code: 0xC0000005
Call stack info:
0x059D0B70 : ?
USER32!0x7E418734 : GetDC
USER32!0x7E42BDF1 : UserLpkPSMTextOut
USER32!0x7E428EA0 : DefWindowProcW
USER32!0x7E42BD34 : UserLpkPSMTextOut
ntdll!0x7C90E453 : KiUserCallbackDispatcher
Dolphin!0x004F26AA : WxUtils::Explore
Dolphin!0x00517CE2 : WxUtils::Explore
Dolphin!0x00518511 : WxUtils::Explore
Dolphin!0x0042EDF8 : wxFrame::`scalar deleting destructor'
Dolphin!0x004AF514 : WxUtils::Explore
Dolphin!0x005490D8 : WxUtils::Explore
main.cpp(52) : WinMain
kernel32!0x7C817067 : RegisterWaitForInputIdle

Actions #26

Updated by XTra.KrazzY about 14 years ago

Issue 1318 has been merged into this issue.

Actions #27

Updated by ayuanx about 14 years ago

I wonder why WxUtils::Explore is called when you press stop button.

Unhandled Exception
Code: 0xC0000005
Call stack info:
ntdll!0x7C911669 : RtlInitializeCriticalSection
ntdll!0x7C91082C : wcsncpy
free.c(110) : free
Dolphin!0x0053C339 : WxUtils::Explore
Dolphin!0x0053C439 : WxUtils::Explore
Dolphin!0x0053C48B : WxUtils::Explore
gamelistctrl.cpp(130) : CGameListCtrl::~CGameListCtrl
Dolphin!0x005487F2 : WxUtils::Explore
Dolphin!0x004D2E9C : WxUtils::Explore
Dolphin!0x004AF654 : WxUtils::Explore
Dolphin!0x00549218 : WxUtils::Explore
main.cpp(52) : WinMain
kernel32!0x7C817067 : RegisterWaitForInputIdle

Actions #28

Updated by nakeee about 14 years ago

Since this is a very generic report, please make other more specific crash on exit
bugs as blocking rather than merging them in.
When you merge in a bug people don't look at the information provided in the original
bug report, which just make all the crash bugs into white noise we will never figure.

Actions #30

Updated by skidau about 14 years ago

  • Status changed from Accepted to Fixed

Closing this issue as there are multiple "crash on stop" bugs. We will track each
crash bug on a case by case basis from here.

Actions

Also available in: Atom PDF