Emulator Issues #12813
closed
Skyward Sword (Wii) - Glitchy/brighter border in some (in-game) areas (Since 5.0-15484)
0%
Description
Game Name?
The Legend of Zelda: Skyward Sword
Game ID?
SOUE01 (00010000534f5545)
MD5 Hash?
e7c39bb46cf938a5a030a01a677ef7d1 (This is my dumped original disc.)
What's the problem? Describe what went wrong.
When loading two of my saves, the top border of the screen has a few brighter lines and glitchy squares, with the exception of OpenGL having the same problem, but at the bottom of the screen instead.
In some areas, the issue isn't visible, but it systematically happens in the same areas.
I checked my three saves and created a new one to verify whether the bug was related to saves, and it seems it is not.
What steps will reproduce the problem?
-Extract the appropriate version of Dolphin.
-Used the attached "GFX.ini" and "Dolphin.ini"
-Make sure the backend is Vulkan.
-Load the game and the save #2 or #3.
-Witness the bug.
-You can remove the bug by "checking" the "Disable Copy Filter" box in the "Enhancements" tab.
Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.
Yes. 5.0-15936
Is the issue present in the latest stable version?
No. Version 5.0.
If the issue isn't present in the latest stable version, which is the first broken version?
5.0-15484 - VideoCommon: Use the copy filter for EFB copies as well as XFB copies (PR 10204 from Pokechu22)
What are your PC specifications? (CPU, GPU, Operating System, more)
- Intel i5-6600
- NVIDIA GeForce GTX970 (driver version 497.29)
- Windows 10 Pro 21H2 (19044.1466)
Files
Updated by pooralmond almost 3 years ago
As always, don't hesitate to ask me questions, as long as you keep in mind that I'm just a "dumb" end-user.
Updated by pooralmond almost 3 years ago
I forgot to mention that bot FIFO logs are recordings of the issue. If you need the recording of an area where the issue is not visible to me, I'll provide you with one.
Updated by pooralmond almost 3 years ago
I updated my GPU drivers with a (allegedly) clean driver installation. 497.29 to 511.23 (Believe it or not, the version before that was 497.29.)
Updated by pokechu22 almost 3 years ago
- Regression changed from No to Yes
- Regression start set to 5.0-15484
To be clear, was this border at the top of the screen present before 5.0-15484 (just without some of the squares), or did that get introduced in 5.0-15484 as well?
Also note that "disable copy filter" is checked by default, since it can reduce blurriness, but having it unchecked is supposed to be more accurate.
Updated by pokechu22 almost 3 years ago
The temple-of-hylia fifolog somehow seems to be a duplicate of the eldin-volcano-area one; can you create a new one for temple of hylia?
Updated by pooralmond almost 3 years ago
To be clear, was this border at the top of the screen present before 5.0-15484 (just without some of the squares), or did that get introduced in 5.0-15484 as well? -pokechu22
*Everything was "fine" before 5.0-15484: no weird bright band at the top, no glitchy/glittery pixels/squares.
Also note that "disable copy filter" is checked by default, since it can reduce blurriness, but having it unchecked is supposed to be more accurate. -pokechu22
I'm trying to keep the "copy filter" (by keeping the box unchecked) for right now. 😅 (Hopefully, it is accurate.)
The temple-of-hylia fifolog somehow seems to be a duplicate of the eldin-volcano-area one; can you create a new one for temple of hylia?
Oops! My bad! I tried to record it right after recording the first fifolog... I wonder what happenned. Here it is, attached to this comment.
Updated by pooralmond almost 3 years ago
Oops... The formatting did not go according to my plan. (I really need to rely more on "Preview". 😅)
Thanks for the awesome work on this emulator, everyone! You are helping me to upgrade my Wii. Even at native resolution and without any bells and whistles, Dolphin is more beautiful than on my launch model plugged over YPbPr on the LCD TV...
Updated by pokechu22 almost 3 years ago
- Status changed from New to Fix pending
Should be fixed by https://github.com/dolphin-emu/dolphin/pull/10396 - you can try it out at https://dl.dolphin-emu.org/prs/f1/49/pr-10396-dolphin-latest-x64.7z.
Updated by pooralmond almost 3 years ago
pokechu22 wrote:
Should be fixed by https://github.com/dolphin-emu/dolphin/pull/10396 - you can try it out at https://dl.dolphin-emu.org/prs/f1/49/pr-10396-dolphin-latest-x64.7z.
Thanks! Yep. Everything is fine now.
Thanks a lot for the quick fix.
I'm eager to read the blog entry when the beta release is published. I bet there will be a lot to talk about. 😅
Updated by pooralmond almost 3 years ago
- File SOUE01_2022-01-26_07-08-43.png SOUE01_2022-01-26_07-08-43.png added
- File SOUE01_2022-01-26_07-08-36.png SOUE01_2022-01-26_07-08-36.png added
Also, here are two screenhots showing the difference when playing with or without the copy filter. The difference is more visible when playing, I think.
I don't know which one is more accurate, but the copy filter seems to create some kind of bloom or light VFX.
That's just a digression of mine... Everything is fine. 😅
Updated by JMC4789 almost 3 years ago
Copy Filter will soften things a bit, but having it used is going to be more accurate. Disabling the Copy Filter in games that don't support it is a hack.
Updated by pooralmond almost 3 years ago
Thanks.JMC4789
JMC4789 wrote:
Copy Filter will soften things a bit, but having it used is going to be more accurate. Disabling the Copy Filter in games that don't support it is a hack.
Thanks. I managed to understand that previously. :)
Will you or someone else write about the manual textures sampling (or whatever the name or that new Dolphin feature is)? It seems to make a difference in Skyward Sword too.
Updated by JMC4789 almost 3 years ago
Manual Texture Sampling is also more accurate. We'll be talking about it in a progress report soon.
Updated by pokechu22 almost 3 years ago
It seems like a similar issue happens in Wii Sports Resort (as with this, only when the copy filter is enabled), which makes sense since during my brief investigation for #10398 it looked like it does bloom in a similar way to Skyward Sword.
Updated by pooralmond almost 3 years ago
This is a bit off-topic, but I want to point out that the black pixels around the little plot of grass and the sprout in the screenshot are not a bug. Those stray pixels are present on the original hardware. This is in the Temple of Hylia, and it's available in my save file, and probably on of the FIFO recording.
Updated by pooralmond almost 3 years ago
I feel very bad for asking, but do you have a very estimated time of arrival for a fix on the dev "branch"?
I'm not that desperate and I know this is all volunteering (and I'm grateful), but I'm also curious about the process. 😅
Again, thanks a lot, everyone!
Updated by pokechu22 almost 3 years ago
When code review is finished - that could be any time, but hopefully it'll make it in before the beta build when progress report comes out (since this regressed after the last beta build (5.0-15445), so it'd be bad to have it in the more stable beta build). Betas are theoretically supposed to be monthly, but that hasn't exactly been what's happened lately :)
Updated by pooralmond almost 3 years ago
pokechu22 wrote:
hopefully it'll make it in before the beta build when progress report comes out (since this regressed after the last beta build (5.0-15445)
I thought about that too. 😅 Thanks for the reply! I'll let the "adults" decide. 😛
Updated by pokechu22 almost 3 years ago
- Status changed from Fix pending to Fixed
- Fixed in set to 5.0-15950
Updated by pokechu22 almost 3 years ago
Turns out it's still broken when EFB to VRAM copies are disabled. Note that "disable copy filter" is ignored (and the copy filter is always used) for EFB to RAM copies. Fortunately the exact same fix works for this; it just needs to be applied in a second location: https://github.com/dolphin-emu/dolphin/pull/10410
Updated by pokechu22 almost 2 years ago
- Related to Emulator Issues #12576: Skyward Sword: Software Renderer produces a more accurate video than any other backend added