Emulator Issues #12853
closed
Add a feature to enable/disable the low pass filter.
0%
Description
Game Name?
[Kirby Air Ride, Super Smash Bros Melee, etc.]
Game ID? (right click the game in the game list, Properties, Info tab)
[GKYE01 and GALE01]
What's the problem? Describe what went wrong.
[On older versions of Dolphin, before commit https://github.com/dolphin-emu/dolphin/pull/9929, the low pass filter being disabled would lead to sharper audio in certain games that did not take major advantage in low pass being enabled. While more accurate to console, I believe having clearer audio is better than being more console accurate in some instances, especially if the low-pass makes the audio sound very muffled.]
What steps will reproduce the problem?
[Use the DSP HLE in a version before the commit listed above. After that, use it in a version after it was re-enabled. The most notable difference is in Kirby Air Ride (GKYE01). The latest Slippi (At time of posting) is the easiest way to test an HLE before the commit.]
Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.
[5.0-16101]
Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)
[https://github.com/dolphin-emu/dolphin/pull/9929 is the commit where the filter was re-enabled.]
Updated by JosJuice about 2 years ago
Have you tested that PR 9929 is the relevant change? The progress report claims that the change in Melee is due to https://github.com/dolphin-emu/dolphin/pull/9955.
Updated by JMC4789 over 1 year ago
- Status changed from New to Won't fix
If I'm giving my honest opinion, I don't think that kind of option should be exposed for general users, and honestly doesn't really suit the needs of a general purpose emulator. I think the only reason anyone cares is that Dolphin sounded "different" prior to the change and to some that sounded better. I've seen the same reaction to Retron style consoles, where they get the pitch a little wrong but some people think it sounds nicer in games.
If Slippi or forks want to make a feature like this, or hell, if someone wants to submit a pull request for more review here, we can probably discuss it. But I'm not sure it warrants an open issue when we've got such a backlog.
Closing as wontfix, but if a pull request is submitted we can revisit this.
Note: There is also a bug around these commits causing some fuzziness to audio in Super Monkey Ball 2. I don't think it affects Melee/Kirby Air Ride, but my ears aren't good enough to be 100% sure.