Emulator Issues #12963: Add option for PNG compression for texture dumps. - Emulator - Dolphin bug tracker

Actions

Copy link

Emulator Issues #12963

closed

Add option for PNG compression for texture dumps.

Added by colorovfire over 2 years ago. Updated over 1 year ago.

Status:

Fixed

Priority:

Normal

Assignee:

% Done:

Operating system:

N/A

Issue type:

Bug

Milestone:

Regression:

Relates to usability:

Relates to performance:

Easy:

Relates to maintainability:

Regression start:

Fixed in:

5.0-19471

Description

When dumping textures, Dolphin uses the default compression level for png’s which is 6. There’s a ton of overhead in this causing a lot of slowdowns. This feature request simply asks that this option be exposed.

I have my own solution for managing png compression so I’d prefer it if I could set it to not compress at all. I mentioned this to @iwubcode and he pointed me to this line:

https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Common/Image.h#L23

I’m currently building my own copy with the change and FMV’s no longer slow down. It runs pretty much full speed all the time. https://youtu.be/HkVJEMBNGUQ?t=161

Actions

Copy link

Updated by iwubcode over 2 years ago

I'll just mention some comments..

The default compression is fast enough for general use imo. However, the user is trying to avoid dynamic texture generation and doing other trickery with a RAM disk. In a typical "dump texture", "edit texture", "test HD texture" workflow, this extra speed isn't really perceivable at all.

A more serious issue is that our current functionality in Dolphin doesn't really support the above workflow very nicely. That is something I'm working on, which is why I haven't implemented this feature requested yet.

I do think this is a feature we should expose. The code section referenced was just a quick workaround for this user and should NOT be what is done to officially add this feature. Maybe I'll just crank this out and then integrate it into my new functionality..

Actions

Copy link

Updated by colorovfire over 2 years ago

If there’s no place for it in the GUI, I’d be perfectly fine if it was only accessible from an .ini setting or command line option. I’d be setting it primarily from the command line.

Actions

Copy link