Emulator

Can you check if breakpoints behave as expected in this pull request? https://github.com/dolphin-emu/dolphin/pull/11077

Thanks for looking at this so quickly. The changes actually break a lot of debugging stuff. Step Over goes wacky. Breakpoints stop the game on wrong addresses, etc. I think the jitasm debugging stuff is necessary for things to function properly.

I went back and looked at my test-removal of this from jitasm:
ABI_PushRegistersAndAdjustStack({}, 0);
ABI_CallFunction(PowerPC::CheckBreakPoints);
ABI_PopRegistersAndAdjustStack({}, 0);

It appeared to work, but now I see it no longer puts our a log message when it breaks on a breakpoints, as jitasm prevents the jit hit on break like you said.

So we have generally working behavior when breaking/pausing on a breakpoint and broken duplication when logging, but not pausing for, the breakpoint. The duplicates on log-only may seem like a minor issue, but are causing bigger issues on future work.

Okay, thanks for testing. Seems like I'll have to do more in-depth testing of this.

I made a mistake. I thought setting a code breakpoint in the code tab would flag it for being logged, but it doesn't. I re-ran my previous test with

ABI_PushRegistersAndAdjustStack({}, 0);
ABI_CallFunction(PowerPC::CheckBreakPoints);
ABI_PopRegistersAndAdjustStack({}, 0);

removed from jitasm and manually setting break and log. Everything looks to be working correctly. This could be a potential fix.

But how about the pull request? Is that one still buggy?

Yeah. The PR makes Breakpoints and stepovers take you to random places. Completely broken.

After doing a bunch of analysis today, I understand why the PR is broken, and I think your solution of removing just those three lines is the best one. I've updated the pull request.

Do note: As far as I can tell from the code, this solution will make breakpoints not trigger when you're using Step. That we don't break when using Step makes perfect sense, but would you consider not logging when using Step to be intended behavior?

I checked a normal build and the Step buttons do not produce a log message at all for me. StepOut will stop on a breakpoint, but produces no log message. Again, that's a normal build and not this bugfix build.

Everything seems to be working good with the latest PR update. I see no changes in behavior.