Project

General

Profile

Actions

Emulator Issues #13172

closed

Software Renderer Crashes with "Compile Shaders Before Starting" or Closing out of a Game

Added by Rno over 1 year ago. Updated over 1 year ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
5.0-18576
Fixed in:
5.0-18807

Description

Game Name?

It crashes with any game.

Game ID? (right click the game in the game list, Properties, Info tab)

N/A

MD5 Hash? (right click the game in the game list, Properties, Verify tab, Verify Integrity button)

N/A

What's the problem? Describe what went wrong.

Whenever I select the Software Renderer backend, enable "Compile Shaders Before Starting," and launch a game, Dolphin throws this error.

Selecting any of the three options crashes Dolphin on Windows 10.
When I deselect "Compile Shaders Before Starting" and launch a game with the Software Renderer, games launch fine, but Dolphin still crashes if you attempt to close out of them.
The rest of the compiler shader options don't seem to affect anything with these crashes.

What steps will reproduce the problem?

  1. Open Graphics window
  2. Select Software Renderer backend
  3. Enable "Compile Shaders Before Starting" option
  4. Launch any game

or

  1. Open Graphics window
  2. Select Software Renderer backend
  3. Launch any game
  4. Close out of the game

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes, 5.0-18690

Is the issue present in the latest stable version?

No

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

5.0-18576

If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer

N/A

What are your PC specifications? (CPU, GPU, Operating System, more)

AMD Ryzen 5 2500U
Radeon RX 560X
16 GB RAM
Windows 10 22H2 19045.2486

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)

N/A


Files

Actions #1

Updated by pokechu22 over 1 year ago

  • Status changed from New to Accepted
  • Regression changed from No to Yes
  • Regression start set to 5.0-18576

Can confirm the message and crash with "Compile Shaders Before Starting". For me, however, I get a message when starting with the software renderer even with "Compile Shaders Before Starting" disabled, and clicking "yes" or "ignore" doesn't cause any further issues (selecting "no" causes a crash by design), and I don't get a message when closing. I probably have some unusual setting enabled though.

Actions #2

Updated by pokechu22 over 1 year ago

This is related to the software renderer not supporting overlays (SupportsUtilityDrawing is false). The ideal fix would be to support it, so that imgui overlays would work with it, but I tried implementing that before and ran into issues. An alternative would be to disable everything imgui related, but it seems like there actually is a lot of imgui stuff that would need to check that.

For whatever reason, this doesn't seem to affect fifoci (and probably (though I haven't checked) DolphinNoGui in general), which is convenient.

Actions #3

Updated by pokechu22 over 1 year ago

  • Status changed from Accepted to Fix pending

Should be fixed by https://github.com/dolphin-emu/dolphin/pull/11582, but because I didn't run into the crash when closing a game, I'd like you to test it; there's a chance that there's a third crash I did not run into.

You can download a test build here: https://dl.dolphin-emu.org/prs/26/0b/pr-11582-dolphin-latest-x64.7z

Actions #4

Updated by Rno over 1 year ago

pokechu22 wrote in #note-3:

Should be fixed by https://github.com/dolphin-emu/dolphin/pull/11582, but because I didn't run into the crash when closing a game, I'd like you to test it; there's a chance that there's a third crash I did not run into.

You can download a test build here: https://dl.dolphin-emu.org/prs/26/0b/pr-11582-dolphin-latest-x64.7z

Can confirm the error and all the crashes are fixed, including when the game is closed. Thank you!

Actions #5

Updated by pokechu22 over 1 year ago

  • Status changed from Fix pending to Fixed
  • Fixed in set to 5.0-18807
Actions

Also available in: Atom PDF