Project

General

Profile

Actions

Emulator Issues #13216

closed

Exporting Wii save files while running any application causes error messages

Added by kaosjr almost 2 years ago. Updated over 1 year ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
Yes
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-19888

Description

Game Name?
All - I noticed it while running the Wii Menu, but it seems to also happen when running disc games (tested w/ Band Hero) and WiiWare (tested w/ Chick Chick Boom)

Game ID? (right click the game in the game list, Properties, Info tab)
None (see above)

MD5 Hash? (right click the game in the game list, Properties, Verify tab, Verify Integrity button)
None (see above)

What's the problem? Describe what went wrong.

When running any application in Dolphin, going back to the program interface and choosing to export a save file causes an error message to pop up. After clicking 'yes' to ignore it, another error message pops up; after ignoring that one the export at least visually seems to complete successfully. See images of error messages.


There does seem to be a save exported after this in the folder selected, so it's possibly not actually harmful, but the error messages indicate something is probably wrong.

What steps will reproduce the problem?

  1. Run any application in Dolphin. (Easiest is probably the Wii Menu).
  2. Swap window over to the gamelist view, and right click a game with a save file.
  3. Click 'Export Wii Save' and select a location.
  4. Observe error message.
  5. Click yes to get through error message, observe a second error message.
  6. Click yes to get through another error message, get message that save was exported successfully.

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes - tested w/ 5.0-19074.

Is the issue present in the latest stable version?

No, as 5.0 has WX as the default GUI... which prevents you from exporting a save if any game is running. (Yes, this is not 5.0, but I can't actually get that version running due to Sysconf issues with my NAND - and it clearly didn't have the issue)

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)
^You should probably stop putting this link in the template, given the bisection tool has been broken for ~3 years now.

Versions that do not let you select where to export saves work as intended. (Versions including and before 5.0-7445)
When PR #6836 (https://github.com/dolphin-emu/dolphin/pull/6836) was merged in 5.0-7455, a selection dialog was added to choose where to select the save. This version is the first to exhibit this issue, though at the time it only suffered from one error message. (It also looks different in this version, as the error handler has been reworked over the years).

I didn't do a full bisect on when the second error message started showing up, but it's somewhere between 5.0-13115 and 5.0-14792 - those just happened to be versions I tested while tracing back to the actual source.

What are your PC specifications? (CPU, GPU, Operating System, more)

i7-8086K, GTX 1070 Ti, Windows 10 x64

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)

I have no idea if my NAND has anything to do with it. There's definitely something wrong with it (I've been trying to export saves for that very reason when I stumbled into this issue), I'm just not confident that it's the thing that's running into a weird edge case during exports as they work perfectly fine when a game isn't running.


Files

Actions #1

Updated by kaosjr almost 2 years ago

Found out while rebuilding my NAND from the ground up that it happens on importing save data if a game is running too, so might help to update the title to reflect that info. Not going to rebisect but my guess is it's the same version.

Actions #2

Updated by JosJuice almost 2 years ago

  • Status changed from New to Accepted
  • Easy changed from No to Yes

We should block these options from being used when emulation is running.

Actions #3

Updated by kaosjr over 1 year ago

I did notice when importing (and forgot to note at the time, whoops) that Real Wiimote seems to break if you do this, which is not exactly surprising.
Of course, this doesn't matter if the options are simply disabled when emulation is running like they were in WX. Guess there was a feature that got forgotten for this long after the switch!

Actions #4

Updated by Hark64 over 1 year ago

Hello, I created a PR to disable "Export Wii Save" and "Open Wii Save Folder" during emulation.
https://github.com/dolphin-emu/dolphin/pull/12093

Actions #5

Updated by JosJuice over 1 year ago

  • Status changed from Accepted to Fixed
  • Fixed in set to 5.0-19888
Actions

Also available in: Atom PDF