Project

General

Profile

Actions

Emulator Issues #13227

closed

compile fail: GBACore.cpp desiredVideoDimensions is now currentVideoSize external mgba core.h

Added by noabody over 1 year ago. Updated over 1 year ago.

Status:
Won't fix
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What's the problem? Describe what went wrong.

Arch Linux build - dolphin-emu-git: yay -S dolphin-emu-git compile fails.

error: ‘struct mCore’ has no member named ‘desiredVideoDimensions’
  308 |   m_core->desiredVideoDimensions(m_core, &info.width, &info.height);

This is due to external module mgba and commit where the function was split into baseVideoSize and currentVideoSize

While it is true that .gitmodules points to commit which retains this function call, Arch's PKGBUILD system uses libmgba which, if built from mgba-git, will contain the latest includes without the function.

With a modified PKGBUILD, that inits the submodule, it also pulls the latest includes. It is possible that a recursive init would bypass the issue. Eventually dolphin-emu will need to adopt the current functions from mgba so I'm reporting this to dolphin-emu upstream as a bug/feature request.

Actions

Also available in: Atom PDF