Emulator Issues #13357
open
Dolphin freezes after adding an encrypted Action Replay code of 128 lines or more.
0%
Description
Game Name?
This bug affect the emulation itself, with or without any game running.
What's the problem? Describe what went wrong.
When you try to add an encrypted Action Replay code ("T7FC-WDKZ-63WVE" format) with 128 or more lines, Dolphin freezes.
Decrypted Action Replay ("000000 000000") with the same number of lines doesn't seem to trigger the bug.
What steps will reproduce the problem?
Properties (of a game)->AR Code (tab)->Add new code...
Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.
Yes (5.0-20122)
Is the issue present in the latest stable version?
Yes.
What are your PC specifications? (CPU, GPU, Operating System, more)
Laptop legion 5 15arh05h (82b1)
CPU: AMD Ryzen 7 4800H @ 2.9-4.2 GHz (8/16)
GPU: NVIDIA GeForce RTX 2060 6GB @120hz (Radeon disabled)
RAM: 16 GB DDR4
OS: Windows 10 x64 (22H2)
Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)
The code I've used to trigger the bug is 16:9 Aspect Ratio v2.3.1de (Widescreen) - Part 1 and part 2 by Ralph.
Source: https://www.gc-forever.com/forums/viewtopic.php?f=38&t=1959
I'm attaching a text file with both codes unified as one.
Files
Updated by AdmiralCurtiss about 1 year ago
Yes, there is indeed an infinite loop in Dolphin's implementation of Action Replay code decryption if you have too many lines in one code. The code here could use some modernization in general, it looks like it was written when our standards were much lower and hasn't been touched since.
Updated by pokechu22 about 1 year ago
It looks like the code is split into two sections on the gc-forever post; I assume it works properly when entered that way?
I am curious what happens if you use a long code like that with an actual Action Replay, but typing in an extremely long code doesn't seem like a fun time so I'm not going to mess with it right now.
Updated by intruso about 1 year ago
pokechu22 wrote in #note-2:
It looks like the code is split into two sections on the gc-forever post; I assume it works properly when entered that way?
Yes, it works properly if you introduce it as two separated codes.