Project

General

Profile

Actions

Emulator Issues #13524

open

GameINI setting for Output Resampling does not change correctly in the GUI (and is also incorrectly listed in the Wiki)

Added by Mors about 2 months ago. Updated about 2 months ago.

Status:
Accepted
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?

Tested mainly with Animal Crossing, applies to all games I'm sure.

Game ID? (right click the game in the game list, Properties, Info tab)

GAFE01

MD5 Hash? (right click the game in the game list, Properties, Verify tab, Verify Integrity button)

7853049ccd0c1e2bffeb5b12393a5409

What's the problem? Describe what went wrong.

Adding the "OutputResampling" field to the GameINI works, but it does not change what's displayed in the Graphics Configuration window.

The said option is also listed as "OutputResamplingMode" in the wiki, which is incorrect and I had to dive into the source code to find the correct name. After finding and using the correct name the resampling option changes correctly, but the drop box text stays the same, which was extremely confusing admittedly.

What steps will reproduce the problem?

  1. Open game properties
  2. Add following to the user config ini:
[Video_Enhancements]
OutputResampling = 5
  1. Run game.
  2. Open the Graphics Configuration window and see it for yourself!

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes, 5.0-21264

Is the issue present in the latest stable version?

The option did not exist back then.

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

Pretty sure it's broken since it's been first added. The AA settings are broken in the same way too, for which there also seems to be a separate bug report made here.

If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer

N/A

What are your PC specifications? (CPU, GPU, Operating System, more)

Windows 11 23H2

Ryzen 5800X3D
GTX 1660 Super
48 GB RAM

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)

N/A


Related issues 1 (1 open0 closed)

Related to Emulator - Emulator Issues #12770: GUI - GameINI Setting AA Is Not Displayed in GUINew

Actions
Actions #1

Updated by Billiard26 about 2 months ago

Actions #2

Updated by JMC4789 about 2 months ago

  • Status changed from New to Accepted

From Filoppi on discord.

it's because in the UI the settings aren't listed in the same order as the enum
but on loading we assume the orders match

Accepting.

Actions #4

Updated by filoppi about 2 months ago

The PR was merged. Please try again

Actions

Also available in: Atom PDF