Emulator Issues #13640
open
GameID Not Loading Correctly - Virtual Console - Super Smash Bros. Brawl Masterpieces
0%
Description
Game Name?
Super Mario World Demo
Game ID? (right click the game in the game list, Properties, Info tab)
HBFE01
MD5 Hash? (right click the game in the game list, Properties, Verify tab, Verify Integrity button)
8b9f77012df1515cc2ee5d474488bdd2e0373e7c
What's the problem? Describe what went wrong.
The extracted VC games from Super Smash Bros. Brawl no longer load the correct GameID, for example Super Mario World Demo which has a GameID of HBFE01 will instead load as RSBE01, which is the GameID for Super Smash Bros. Brawl.
Not picking up the correct GameID means the wrong title is given to the running game and also the wrong GameINI will load, so the correct settings are not applied
What steps will reproduce the problem?
Run a VC game extracted from Super Smash Bros. Brawl
Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.
Yes, 2409-65
Is the issue present in the latest release? For future reference, please also write down the version number of the latest release.
Yes, 2409
If the issue isn't present in the latest release, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)
The issue originated from the following build:
5.0-8935 -> https://dolphin-emu.org/download/dev/74c49c961ed4ade307b04f600536fed1f9b26ea4/
https://github.com/dolphin-emu/dolphin/pull/7504
If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer
N/A
What are your PC specifications? (CPU, GPU, Operating System, more)
i7-4790K
RTX 2060 6GB
Windows 10
16GB DDR3
Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)
Let me know, I'll see what else I can do.
Updated by autofire372 3 months ago
I just reproduced this by launching Super Metroid from within Brawl. The titleid does not change from RSBE01 to JAVE01.
Updated by autofire372 3 months ago
I tested again by extracting the entire partition from Brawl and running HBIE01's main.dol directly from Dolphin. The same symptoms apply, as the wrong gameID means Safe Texture Cache isn't forced on, leading to expected graphical issues.
Updated by JosJuice 3 months ago
- Status changed from New to Questionable
There are two problems in play here.
The first problem is the one you reported happening for extracted VC games. When you extract a partition, one of the folders that get created is the "disc" folder. This folder contains data that isn't actually taken from the specific partition, but from data from the area at the start of the disc, before the partitions. This is where Dolphin is picking up RSBE01 from. If you delete the "disc" folder, you will get the behavior you're expecting. We could revert https://github.com/dolphin-emu/dolphin/pull/7504, but since this causes undesirable behavior for certain hacked games, I would say asking you to delete the "disc" folder is the better solution. (Possible idea: What if Dolphin only created the "disc" folder when extracting the DATA partition, not other partitions...?)
The second problem is the one you reported happening when launching Super Metroid from within Brawl. The bisect for this problem is https://github.com/dolphin-emu/dolphin/commit/8842a0f402ffe60a80ce7894bfd36afd039009fc. This change split Dolphin's tracking of the game ID into two variables: The game ID and the GameTDB ID. The former is used for loading game INIs, and the latter is used for displaying metadata to the user. The bug introduced by https://github.com/dolphin-emu/dolphin/commit/8842a0f402ffe60a80ce7894bfd36afd039009fc led to the GameTDB ID being incorrectly set, but the game ID is still correctly set, so the game INI should be properly loading as far as I know. I've created https://github.com/dolphin-emu/dolphin/pull/13101 to fix the problem with setting the GameTDB ID.