Project

General

Profile

Actions

Emulator Issues #13669

open

First build fails on macOS due to empty Info.plist

Added by TellowKrinkle about 1 month ago. Updated 28 days ago.

Status:
Accepted
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
OS X
Issue type:
Bug
Milestone:
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
5.0-21610
Fixed in:

Description

Game Name?

N/A

Game ID? (right click the game in the game list, Properties, Info tab)

N/A

MD5 Hash? (right click the game in the game list, Properties, Verify tab, Verify Integrity button)

N/A

What's the problem? Describe what went wrong.

When attempting to build Dolphin with the makefile generator on macOS, the first build generates a Dolphin.app with a blank Info.plist, making the application unusable and post-build fixup steps that read the Info.plist (like postprocess bundle, etc) fail.

What steps will reproduce the problem?

  1. Clone the Dolphin repo
  2. Install any required dependencies
  3. Use cmake to generate a makefile (Ninja works fine), e.g. cmake -B build -DSKIP_POSTPROCESS_BUNDLE=ON
  4. Attempt to build Dolphin (make -C build -j16)

Expected Result:
The build succeeds and a working Dolphin.app is generated

Actual Result:
The build fails with

[100%] Built target dolphin-emu
/tmp/dolphin-build/Binaries/Dolphin.app/Contents/Info.plist: Property List error: Cannot parse a NULL or zero-length data / JSON error: Unable to parse empty data.
make[2]: *** [Source/Core/CMakeFiles/build_final_bundle] Error 1
make[1]: *** [Source/Core/CMakeFiles/build_final_bundle.dir/all] Error 2

The resulting Dolphin.app has an empty Info.plist, making it not a valid Application according to macOS
Running make a second time will rerun cmake, which will generate a working Info.plist

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes (Commit 7e1074b140809b0da7aa7d02b6303a68cc351be2)

Is the issue present in the latest release? For future reference, please also write down the version number of the latest release.

Not an issue with compiled binaries

If the issue isn't present in the latest release, which is the first broken version?

Broken by https://github.com/dolphin-emu/dolphin/pull/12728

If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer

N/A

What are your PC specifications? (CPU, GPU, Operating System, more)

i9-9980HK
AMD Radeon Pro 5600M
MacOS 14.6.1

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)

Actions #1

Updated by OatmealDome 28 days ago

  • Status changed from New to Accepted
  • Regression start set to 5.0-21610
Actions

Also available in: Atom PDF