Project

General

Profile

Actions

Emulator Issues #1396

closed

Enabling Interpreter without game running crashes

Added by BhaaL over 14 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What steps will reproduce the problem?

  1. Run Dolphin in Debug mode
  2. With no game running, select "JIT > Interpreter Core" or "JIT > JIT off (JIT core)"
  3. Crash in JitBlockCache::Clear

What is the expected output? What do you see instead?
Instead of a crash, nothing should happen.
Or even better, the menus should be disabled by default. Having them active
with no game running had me enable Interpreter before running the game,
resulting in the crash.

What version of the product are you using? On what operating system?
Rev. 4253 on WinXP Pro SP2

Please provide any additional information below.
See this patch for a possible fix:
http://pastie.org/613645
As said above, it would probably be better to disable the menus altogether,
since it also affects other things.
For example, this breaks the "Play/Pause" Button of the Debugger when
running a game. It stays disabled until you click another button, for
example "Show PC".

Actions #1

Updated by BhaaL over 14 years ago

Hmmm, just wondering, is this "return" there on purpose?
http://code.google.com/p/dolphin-emu/source/browse/trunk/Source/Core/DebuggerWX/Src/CodeWindow.cpp#681

It seems to be the cause of the not-updating there...

Actions #2

Updated by BhaaL over 14 years ago

It seems r4223 introduced that "return".
Also, the other returns and comments (see my comment on r4223) seem to work for me
with r4253, at least I did not get any surprising crashes or the likes...

Actions #3

Updated by hrydgard over 14 years ago

  • Status changed from New to Accepted

i'll take this one

Actions #4

Updated by sl1nk3.s over 14 years ago

wasn't that fixed already ? :d

Actions #5

Updated by BhaaL over 14 years ago

Uh, this was supposedly fixed by the UI changes (JP introduced a bunch of returns in
the code that simply cancelled enabling/disabling of menus amongst other stuff).
So I guess this counts as fixed.

Actions #6

Updated by GCNWIIUploader over 14 years ago

omg jp dd something helpful

Actions #7

Updated by BhaaL over 14 years ago

No, he added the returns, breaking it.
Someone reverted those ("fixed by the UI changes"), effectively disabling the
possibility of trying this again.

Actions #8

Updated by BhaaL over 14 years ago

FYI, nakeee removed the returns in r4272.

Actions #9

Updated by sl1nk3.s over 14 years ago

  • Status changed from Accepted to Fixed

erm, marking as fixed :p

Actions

Also available in: Atom PDF