Emulator Issues #13966
open
Just Dance (SDNP41) will not launch if Progressive Scan is enabled
0%
Description
Game Name?
Just Dance
Game ID? (right click the game in the game list, Properties, Info tab)
SDNP41
MD5 Hash? (right click the game in the game list, Properties, Verify tab, Verify Integrity button)
ee8cf51f3855dda1be2adf415141c75c
What's the problem? Describe what went wrong.
The game does not intialize if it is launched directly from Dolphin's UI. It will hang on a blank screen.
What steps will reproduce the problem?
- Enable "Progressive Scan" in Settings > Graphics > Advanced
- Launch the game directly from the UI.
Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.
Not sure, but likely
Is the issue present in the latest release? For future reference, please also write down the version number of the latest release.
Yes - 2614969fa80dfeb87d2a4ad3bdaa703237127074 (2512)
If the issue isn't present in the latest release, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)
N/A - this issue has existed since as far as I can remember. Have added information on the Wiki.
If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer
It's a blank screen, I don't see any purpose in uploading a blank screen.
What are your PC specifications? (CPU, GPU, Operating System, more)
- AMD Ryzen 5 4600H
- AMD Radeon RX 5500M
- 16GB RAM
- Bluetooth passthrough (J27H002)
- Windows 10 Enterprise (x64)
Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)
If I launch the game using the disc channel (File > Change Disc...), the game works as expected. So there must be a fringe case that is specific to this game. It does not occur on subsequent Just Dance titles, and I can't test the NTSC version. Considering this behavior, I believe in good faith that this is an emulation bug. If any further logs are required, please let me know.
Files
Updated by Someone7272 4 months ago
According to Wii support page:
Games that do not support 480p will be displayed in 480i.
So what’s going on here? Does the disc channel silently override 480p to 480i mode?
Then this would make sense that launching the game directly from the UI, Dolphin might not handle this correctly and tries to force 480p mode.
Updated by
Updated by Someone7272 3 months ago
- File just_dance_disc_channel_truncated.txt just_dance_disc_channel_truncated.txt added
- File just_dance_dolphin_ui_full.txt just_dance_dolphin_ui_full.txt added
JMC4789 wrote in #note-2:
I don't have this particular Just Dance, but can you compare the logs (you'll have to enable them in View -> Log and Log Configuration, enable them, and set it to info) and see where they diverge when booting the game?
Hi, thanks for looking at this. Initially I didn't include the logs, because there wasn't anything that jumped out at me.
However, I will include them here verbatim. There's too much to include in this post, so I have added them as .txt attachments.
Observations
I don't know C++, I'm learning Rust instead, so I won't be much help here. However, the critical point of deviance seems to be around line 3659 in just_dance_disc_channel_truncated.txt. There's gonna be noise here, as it includes the full Wii Menu boot phase. Launching the game directly from the Doplhin UI would of course skip the Wii Menu boot phase.
As expected, the just_dance_dolphin_ui_full.txt log is completely different and I couldn't spot any patterns that jump out at me here.
Updated by flacs 2 months ago
· Edited
- Status changed from New to Accepted
This is a bug in the game and affects all regions. The hang condition when the game boots is as follows:
- The system menu is configured to "EDTV/HDTV (480p)" and
- a component cable or D-Terminal cable is plugged in and
- the current scan mode is interlaced.
The game tries to wait 2 seconds for the TV to switch modes but never actually updates the loop counter.
You can even hit this hang on hardware by plugging in a component or D-Terminal cable after the system menu has already booted in interlaced mode.
Dolphin started hitting the hang since https://github.com/dolphin-emu/dolphin/pull/2731 but only for the PAL version.
Updated by Someone7272 2 months ago
flacs wrote in #note-4:
This is a bug in the game and affects all regions. The hang condition when the game boots is as follows:
- The system menu is configured to "EDTV/HDTV (480p)" and
- a component cable or D-Terminal cable is plugged in and
- the current scan mode is interlaced.
The game tries to wait 2 seconds for the TV to switch modes but never actually updates the loop counter.
You can even hit this hang on hardware by plugging in a component or D-Terminal cable after the system menu has already booted in interlaced mode.
Dolphin started hitting the hang since https://github.com/dolphin-emu/dolphin/pull/2731 but only for the PAL version.
Thanks for the insight, but I'm still a bit puzzled on this. Please can you elaborate more on what's different for interlaced vs progressive scan modes when we launch a game directly from the Dolphin UI, compared to when we start the Wii menu and load the game from the Disc Channel?
This implies that when launching a game from the UI, Dolphin always starts in interlaced mode, then it's up to the game to switch it to progressive which causes the hang. But I would have thought that Dolphin would simply start in progressive if this is configured in the application settings.
When starting the Wii menu, does this initialize in progressive mode (or switch from interlaced to progressive at startup)?
I did notice when I launch the game from the Disc Channel, there is a "Video config changed, reloading shaders" message.
The codebase has moved on since that PR was made, but glancing at it looks like there's a simple check on the m_clock value if the disc is NTSC. This will always return false for PAL games, so I'm assuming m_clock doesn't get the 54MHz value - which theoretically would apply to all PAL games.