Emulator

To add more. Since the recent OpenGL optimization, Naruto EX series for the WII are
missing the Floor texture of the combat arena.
D3D is fine.

Note, for naruto ex, the texture is missing but its not black its kinda 1 coulour,
(Gouraud)

There hasn't been recent GL work. at least for a few days anyway.

Well its not so old either.
Its the optimization of rodolfoosvaldobogado. (rev 4322) that I were talking about.
The problem could be related with 4353 too. Anyway I dont remember the exact commit
between this too but I know its those. Any Rodolfoo..... said to heavy test so I did
and here I report.

I'll check, thanks for the testing :)

Some screenshots showing the bug in SSBB's Bridge of Eldin stage:
http://img18.imageshack.us/img18/4750/78551429.png
http://img5.imageshack.us/img5/250/19863856.png
This problem also occurs in Tatsunoko vs. Capcom.

Well, after get ssbb and try to see the error for myself, surprisingly no error at
all, not in the intro, not in the bridge stage.

http://img195.imageshack.us/img195/4452/screen1za.png
http://img132.imageshack.us/img132/6744/screen2aq.png

Could you post your hard/drivers/emu configuration detail?

Thanks to Ricardo for lend me the game for testing :)

sorry for the last one, i already see your detail, is the emu configuration i'm
interested :)

My emu config is ass follows:
General:
Dual Core enabled
Idle skipping enabled
unlimited jit cache enabled
Framelimit off
watchdog 15
Advanced settings:
HLE the IPL enabled
JIT recompiler enabled
Lock threads to core enabled
Optimize Quantiziers enabled
DSP on thread enabled
WII tab:
Nothing checked aspect ratio 16:9
OpenGL settings:
Only autoscale is checked
antistropic filter 1x
everything else off
Advanced:
Overlay FPS is checked everything else is not.
EFB copy to GL texture(hack) is enabled
No hacks
DSP HLE settings:
everything enabled but RE0 audio

Thats it.

REV 4469. still no ground texture for Naruto EX 3 when using OpenGL.

The exact rev that broke it is REV 4322

Ive made improvement,
Rodo.From Rev 4494 if I revert VertexManager.cpp AND VertexManager.h
To rev 4321, The texture is back. (a bit corrupted) but its back at least.

so I hope this can help you pin point the problem.

Still an issue?

Yes

Taken from what we tested of the change in 4322. Its a problem that seem to affect
only nVidia user.
Tested on ATI and there is no missing texture.
It seem to affect only some type of nvidia card. Like mine GTX 295. Ill try to test
more videocard and report back here.

Ok. I got something interesting.
I have tried a asus laptop with a GTX 260M. The problem is the same.
Driver is the latest nVidia WHQL 191.07
THis driver reported by Furmark seem to use opengl 3.2
I installed and older driver , 1 that come on windows update and is driver 186.31
In furmark, it report opengl 3.0 and the best part of it is that the texture is back.
Some to problem is kinda solved.
I still see a weird thing over the texture tho... It wasn't happening before. and not
happening on ATI hardware.

Question IS, is it a nVidia driver issue or simply something being done not
correctly according to OpenGL specs...
Ill let the devs find out :P since im only a casual users.

extra: This is probably why some older nVidia card doesnt have the issue, people
using older driver or nvidia card not supporting latest 3.2 opengl extension.

Just updating to say the issue is still present.

This happen in NSMB in opengl. No problem on DX.

Mario eyes are missing.

how about now?

Issue is still present on nVidia cards.

Problem still present on R5459. Just to recap, Rev 4322 broke it.

@rodolfoosvaldobogado
I found how to almost completely fix the problem R4322
Just replace in VertexManager.cpp :#define MAX_BUFFER_SIZE 0x50000
to the old value of 0x4000

The texture missing in Naruto ex3 is now 80% back. (it was 100 missing before).
Maybe you can figure out the rest of the problem.

The problem seem when MAX_BUFFER_SIZE go to more than 4 digits after the X
Ex: 0x9000 work
0x10000 doesnt work

Ops it seem that even when using 0xffff doesnt work.
Il try to find the max valur of this and report back a perfect value if I can find one

I have now tryed a lower value aka 0x1000. game are working better everytime I lower
the vallue.
At 0x1000 naruto ex3 texture is almost perfect.

it seems to be a limitation in buffers size of nvidia cards, some one can confirm
that this not happening on ati cards?

I have a ATI card too in another computer and Naruto EX3 doesnt have this problem with
a 50000 value.

Lowering the value is not Completely fixing the problem.But it getting close to R4321
(before your R4322 commit)

Ill post some screenshot soon to show the difference.

Here are the screen shot from r5457 original and r5457 with a Maxvbuffer value of 1000

please test my next xommit to see if it fix the problem

Sadly it doesn't work. Thanks for the effort tho.

Rev4321 also cause the SPS in Luigi's mansion. in the intro. Rev4320 doesn't have the
problem.

Sry I keep saying 4321 while the problem is in 4322... sry

Why increasing the max buffer size cause problems? It doesn't make sense to me...

Buffer at 0x3000

@dfle...@gmail.com, The buffer value may not be the real cause of the problem because
it does not seem to impact the SPS in Luigi's mantion that was created with r4322
Probably messing with this setting only improve things on certain games but still, I
cant obtain a perfect texture on EX3 like I have on my Radeon or with older rev than
r4322.

Buffer at 0x4000

Why did you delete your youtube videos =/

Because it was old (oct 2009)and not related to what we are doing now.(vbuffer change)

I managed to fix/ workaround the issue for luigi mansion and possibly, Naruto ex3,
corrupted mario in NSMB
In render.cpp for the opengl plugin,
Line 561
Replace: VertexShaderCache::DisableShader();
by : glDisable(GL_VERTEX_PROGRAM_ARB);
line 595

replace : VertexShaderCache::EnableShader(0);
BY: glEnable(GL_VERTEX_PROGRAM_ARB);

Have fun testing.

Its not just a possibility now, Naruto ex3 and the corruption of mario eye/ weird line
in the intro of NSMB is now fixed with this.

Rodolfoo will still have to look into this because im bypassing his vertexshadercache
and using the old model.
Rodolfoo Pixelshader cache is still enable tho.

Here is the DLL. used under R5519. will problably work on the recent Rev too.

don't worry, found the real problem, will fix in my next commit, thanks for finding
the error :)

Hope this helped :)

helped a lot wagnard28, the problem was in the shader caching now is solved i hope

Excellent, I'll test the commit when its ready.

Patch that fix the problem.

A patch that make things work as it was intended at first by rodolfoo. No more issue when using XFB and no need to replace VertexShaderCache::DisableShader(); by glDisable(GL_VERTEX_PROGRAM_ARB); anymore.

Works on nVidia and ATI.
Issue can probably be close after this commit.

Bumping.. Rodolfo can you check that patch?

(I really should learn ogl :P)

This issue as been fixed . It just didnt got closed when it happened.