Project

General

Profile

Emulator Issues #153

DX9 Video Pixel-Shader Generator Bugfix

Added by XTra.KrazzY almost 12 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Hello,
I've decided to help progress the video plugin by turning on the
notification on shader compilation errors. On LoZ:WW, I was showered with
the same error message "Invalid subscript 'a'". Turns out that the
generator has, in addition to registers, a "0.0" value. You compile it in
most cases as a regular register, providing DX with, for example "0.0.a"
and "0.0.r".

Attached here is the patched PixelShader.cpp
(Source/Plugins/Plugin_VideoDX9/Src/PixelShader.cpp)

I hope it solves some stuff. After all, I've been testing LoZ:WW for quite
some time and there were no shader compilation errors whatsoever.

A nice addition would be more debug printouts(message boxes) to the video
plugin

History

#1 Updated by Sonicadvance1 almost 12 years ago

posting a patch file would be a lot easier than the entire changed file.
Not sure how it works in Windows though

#2 Updated by XTra.KrazzY almost 12 years ago

Yeah, usually in *NIX I'd do a diff but I just don't have the time to mess with
Windows and its stuff. The changes are pretty much distributed in the file so I can't
just copy and paste what to change.

#3 Updated by XTra.KrazzY almost 12 years ago

May I commit stuff myself?

#4 Updated by XTra.KrazzY almost 12 years ago

Another (now diff -urN) version with a fix/optimization (Is it just me or did
framerate increase by ~1-2 FPS?)

It would've been a lot easier if I could commit... meh

#5 Updated by hrydgard almost 12 years ago

  • Status changed from New to Accepted

Cool, thanks. You got access. (you'll need to recheckout, i guess, and your password
is in Settings).

#6 Updated by fires.gc almost 12 years ago

  • Status changed from Accepted to Fixed

Also available in: Atom PDF