Actions
Emulator Issues #1844
closed
Multibyte Issues in NetPlay (wxString::Format with plain c-strings)
Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:
0%
Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
Description
What steps will reproduce the problem?
- Start NetPlay.
- Connect a client.
- Client will see garbage with "Connection established to [garbage]"
Please provide any additional information below.
sanchez reported this on IRC, and it seemed to be related to the use of
wxString::Format with wxT and plain c-strings as format parameters (might
also be related to Issue 195).
See this patch for a few (janitorial) changes that should fix this;
replacing Format calls with %s format specifiers (that were not first
converted to UTF8) with wxString::FromAscii and StringFromFormat does the
trick:
http://pastie.org/754572
Updated by BhaaL over 14 years ago
Whoops, guess the last change with the Chat should not be there (NetWindow.cpp:471).
This breaks chat, as m_Chat->GetValue() is correct already (which also explains why
m_Nick was converted to UTF8, but the chat string was not)
Updated by
Actions