Project

General

Profile

Actions

Emulator Issues #1868

closed

Could not build: stop because errors (r4736)

Added by gide_x almost 15 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What steps will reproduce the problem?

  1. Building

What version of the product are you using? On what operating system?
SVN r4736 on Linux 2.6.24-23-server i686 Ubuntu

What is the expected output? What do you see instead?

Hello!
I've a build error (with update first, and with a clean new download from SVN):

Compiling shared
Build/Linux-i686-release/Source/Plugins/Plugin_Wiimote/Src/ConfigPadDlg.os
Source/Plugins/Plugin_Wiimote/Src/ConfigPadDlg.cpp: In member function
'void WiimotePadConfigDialog::OnKeyDown(wxKeyEvent&)':
Source/Plugins/Plugin_Wiimote/Src/ConfigPadDlg.cpp:219: error: conversion
from 'char [128]' to 'const wxString' is ambiguous
/usr/include/wx-2.8/wx/string.h:692: note: candidates are:
wxString::wxString(wxChar, size_t) <near match>
/usr/include/wx-2.8/wx/string.h:682: note:
wxString::wxString(int) <near match>
Source/Plugins/Plugin_Wiimote/Src/ConfigPadDlg.cpp:220: error:
'SaveKeyboardMapping' was not declared in this scope
Source/Plugins/Plugin_Wiimote/Src/ConfigPadDlg.cpp: In member function
'void WiimotePadConfigDialog::CreatePadGUIControls()':
Source/Plugins/Plugin_Wiimote/Src/ConfigPadDlg.cpp:492: warning: unused
variable 'TxtW'
Source/Plugins/Plugin_Wiimote/Src/ConfigPadDlg.cpp:492: warning: unused
variable 'TxtH'
Source/Plugins/Plugin_Wiimote/Src/ConfigPadDlg.cpp: In member function
'void WiimotePadConfigDialog::UpdateGUI()':
Source/Plugins/Plugin_Wiimote/Src/ConfigPadDlg.cpp:1106: error: 'slot' was
not declared in this scope
scons: ***
[Build/Linux-i686-release/Source/Plugins/Plugin_Wiimote/Src/ConfigPadDlg.os] Error
1
scons: building terminated because of errors.

Best Regards
JD

Actions #1

Updated by gide_x almost 15 years ago

Precision: r4735 build OK

Actions #2

Updated by Anonymous almost 15 years ago

Yes I have this problem as well, I really want to build this.

Actions #3

Updated by Anonymous almost 15 years ago

If someone has a fix, I would really like to hear it.

Actions #4

Updated by giantpune almost 15 years ago

i get this also. ubuntu 9.10, amd64. my scons version is 1.2.0, trying to build r4738.

Actions #5

Updated by gide_x almost 15 years ago

OK, so...... I'm NOT a C++ developper, and I don't understand all in C++ (and I speak
not very well english :) ), but I've seen 3 things in ConfigPadDlg.cpp that are
illogics for me... (changes were made between r4729 and r4736)

I explain my point of view:

line 219: SetButtonText(ClickedButton->GetId(), keyStr);

This line was unchanged but keyStr is in String and it seems must be in wxString...

I've correct this problem by remplacing by this:
SetButtonText(ClickedButton->GetId(), wxString::FromAscii(keyStr));

I've been inspired by the modif at line 209.....

Line 220: SaveKeyboardMapping seems not existing in new release and be replaced by
SaveButtonMapping
My replacement: SaveButtonMapping(ClickedButton->GetId(), XKey);

I've been inspired by the modif at line 212.....

Line 1106 : [slot] don't exist in declaration....

Replace [slot] by [m_Page]

Now the build would pass...

I repeat one more time: I'm not a developper and if somebody could correct me (or
confirm my diff in the best case), that's would be cool.....

Best regards.
JD.

Actions #6

Updated by BhaaL almost 15 years ago

I cannot compile this since my VM is acting up, but from looking at the code the
fixes should be fine.
slot looks like a copy/paste mistake, while the others are iddef'd code thats easy to
miss.

Actions #7

Updated by teranine almost 15 years ago

GID's changes to ConfigPadDlg.cpp seem to work for me and the build completes.

Actions #8

Updated by ayuanx almost 15 years ago

seems r4744 has fixed it :)

Actions #9

Updated by ayuanx almost 15 years ago

  • Status changed from New to Fixed
Actions

Also available in: Atom PDF