Emulator Issues #1890
closed
[Patch] Scons fix for MacOSX
0%
Description
The following issues might appear on MacOSX when trying to compile Dolphin
using scons:
-
NameError: name 'wxmods' is not defined:
File "SConstruct", line 312: env['HAVE_WX'] = conf.CheckWXConfig('2.8',
wxmods, 0) -
AttributeError: 'tuple' object has no attribute 'startswith':
File "SconsTests/utils.py", line 9:
if not flag.startswith('-W') -
might appear on 64-bit Leopards (also snowy ones) that do not pass
osx=64cocoa (or intentionally want to build a 32-bit Dolphin, who knows).
This is due to the check on line 292 that checks for darwin first, and then
only for 64cocoa. For darwin and non-64cocoa, wxmods was not defined at all. -
also appears in combination with 1) when parameters like "-arch=i386"
are passed and added as tuple. This causes utils.py to barf on the tuple,
effectively failing the build.
I am by no means a python coder, but I managed to throw together something
that works on my Snow Leopard: http://pastie.org/761665
Updated by nakeee over 14 years ago
Does it work on older than snow lepord osx?
where is that -arch=i386 from?
Updated by BhaaL over 14 years ago
I guess line 282 of the SConstruct adds this: compileFlags += ['-arch' , 'i386', '-m32' ]
I did (could) not try it with Leopard yet, since my laptop isnt working that well
lately. However, since it just merges the if around line 293 (which leaves "darwin
and not 64cocoa" out of the equation), it should technically not break anything.
Infact, i think 32-bit builds on MacOSX should have been broken since r4389, but the
lack of OSX devs/testers (on 32-bit OSX or SL without osx=64cocoa) did not yield this
result earlier.
With those fixes to the scons, my build is currently still failing to find
Cg.framework, but thats a different story (a bit off-topic, but does anyone happen to
know how to tell scons where to look for them? or rather, print where it looks for
them right now?)
Updated by BhaaL over 14 years ago
- Status changed from New to Fixed
This issue was closed by revision r4843.