Project

General

Profile

Actions

Emulator Issues #2019

closed

GUI selection bar issue (new URL: http://tinyurl.com/ykp8mnj )

Added by shadoweffex almost 15 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What steps will reproduce the problem?

  1. Simply open up any recent revision of Dolphin
  2. Select a random game in the GUI list
  3. The selection bar isn't covering all columns

What is the expected output? What do you see instead?
The selection bar should cover all columns including the Wii/GC icons,
Country flag and the Rating

What version of the product are you using? On what operating system?
Any recent Dolphin SVN Revision (in my case, R4829)

Please provide any additional information below.
Screenshot: http://www.xs4all.nl/~vdnoort/emulation/dolphin/
dolphin_gui_error.jpg


Related issues 1 (0 open1 closed)

Has duplicate Emulator - Emulator Issues #2018: GUI selection bar issueDuplicate

Actions
Actions #1

Updated by shadoweffex almost 15 years ago

Accidentally posted a double issue. Either delete this one or the other one.

Actions #2

Updated by j.rechards almost 15 years ago

Hey how do you get the internet channel in dolphin :D (wiiware)

Waar haal je het internetkanaal vanaf? :D

Actions #3

Updated by jayork42 almost 15 years ago

Dupe issue.

Actions #4

Updated by hyperiris almost 15 years ago

Issue 2018 has been merged into this issue.

Actions #5

Updated by shadoweffex almost 15 years ago

@j.rechards

Officially, you have to extract it from your Wii.

Actions #6

Updated by j.rechards almost 15 years ago

Hummmm i dumped my wii already, but didnt have the internet channel installed, i dont
want to dump it again, fuck it :P

Actions #7

Updated by hyperiris almost 15 years ago

well, I can't reproduce this, and it was a fixed issue I think.
My OS is windows 7 x64, both x86 and x64 version of dolphin tested.

Actions #8

Updated by hyperiris almost 15 years ago

with more test under windows xp, I can reproduce this issue.

Actions #9

Updated by shadoweffex almost 15 years ago

If I remember correctly, JPeterson was working on the GUI at the time when I started
noticing it. And yes, I'm also using Windows XP (32bit).

Actions #10

Updated by ayuanx almost 15 years ago

This is most annoying due to the limitation/bug of wxWidgets on Windows XP. To make
the icons still visible when a row is selected, you have to make it look like this:

Actions #11

Updated by XTra.KrazzY almost 15 years ago

  • Status changed from New to Questionable

Not sure about this being an actual issue.

Actions #12

Updated by sl1nk3.s almost 15 years ago

This is more like a wxwidgets issue with windows XP only..
We can bypass it by drawing directly on top of the wxList, but still it's annoying

Actions #13

Updated by ayuanx almost 15 years ago

sl1nk3.s, the problem is the size of imagelist is 96x32, but for some icons (e.g.
paltform, flag) only partial of it like 32x32 are valid pixels, other pixels are
transparant. So when an icon of 96x32 is put into a column of 32x32, it is sitll
fine. But when this row is selected, this clamped icon won't be shown by wxWidgets on
WinXP.

Actions #14

Updated by ayuanx almost 15 years ago

So I made all columns 96x32, then they can be shown even when selected, but another
issue emerged: transparancy and mask, so you get the result as shown in the snapshot
above. (the transparant pixels are not masked when they are in selection.)

Actions #15

Updated by sl1nk3.s almost 15 years ago

ayuanx, that's true, i had the same issue on windows XP and found the same reasons
for the issue (= the size of the colums, icons partially hidden won't be drawn when
selected)
But still this is an issue with wxWidgets, as we can't use different image sizes,
plus as you said transparency isn't supported

Actions #16

Updated by ayuanx almost 15 years ago

True, but if you are gonna draw those icons directly on top of the wxList, you also
have to handle the selection mask manually, that could be annoying too. Is there any
wxWidgets patch for this issue?

Actions #17

Updated by shadoweffex almost 15 years ago

Thanks guys, the selection bar indeed does it more properly when the icon columns
are double clicked to alter their width. However, that exposes another problem
namely getting the (icon)columns back to their original width.

I am almost sure it was working in a way earlier revision where the selection bar
would cover the full record including the icons.

Actions #19

Updated by hrydgard almost 15 years ago

fixed link

Actions #20

Updated by nakeee almost 15 years ago

  • Status changed from Questionable to Accepted

Any idea how to solve that one?
being windowsless I can't help much:)

Actions #21

Updated by sl1nk3.s almost 15 years ago

I had a wxwidgets patch around to solve this, but touching wx was seen as something
really gross by shuffle2 so I dumped it :P
That's definitely an issue with wxWidgets though, also, that bug is windows-only see
the corresponding issue report on their bug tracker :
http://trac.wxwidgets.org/ticket/3195 (note that the bug was filed 4 years ago, and
got last modified one year ago... yay there's hope)

Actions #23

Updated by BhaaL almost 15 years ago

I don't like this patch, it reverts some changes inside wxwidgets.
And for now, I wouldn't worry about this slight UI issue.

IMO the GameListCtrl should be reworked to either use the preferred wx-way of doing
it (rather than hacking a windows-specific thing back in); or to revamp the control
completely - theres been ideas and concepts about how to make it more compact, less
overloaded and things.

Actions #24

Updated by sl1nk3.s almost 15 years ago

  • Status changed from Accepted to Fixed

should be fixed in r5100, wxWidgets is unmodified too.

Actions #25

Updated by shadoweffex almost 15 years ago

Fix confirmed!

Actions

Also available in: Atom PDF