Project

General

Profile

Actions

Emulator Issues #2053

closed

Single Core + x64 + JIT + Paired Single Store Quantized = kills dolphin.

Added by interdpth over 14 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
Category:
JIT
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Unchecking dual core support kills dolphin.
The problem lies in VertexManager.cpp, in the function Flush(); And it
occurs with this line
glBindBuffer(GL_ARRAY_BUFFER, s_vboBuffers[s_nCurVBOIndex]);

I have no clue how to fix it. So hoping someone will =p


Related issues 4 (0 open4 closed)

Has duplicate Emulator - Emulator Issues #2038: Emulator is broken in svn revisions 4854 and up on linuxDuplicate

Actions
Has duplicate Emulator - Emulator Issues #2106: Dolphin crashes if dual core is not enabledDuplicate

Actions
Has duplicate Emulator - Emulator Issues #2143: Tales of Fantasia : Single Core crashDuplicate

Actions
Has duplicate Emulator - Emulator Issues #2351: single core JIT crash DolphinDuplicate

Actions
Actions #1

Updated by DStaticD over 14 years ago

It never happened to me. I use r4883.

Actions #2

Updated by Anonymous over 14 years ago

Hm....perhaps there is a bad memory access in a thread which is hiding the real issue
or something. I once tracked one down like this that ended up being a buffer overflow
in the dsp plugin...quite annoying to find.

However, unless someone can reproduce this there's really nothing to do.

Actions #3

Updated by marcel.werner3 over 14 years ago

hm, he's right. With dual core unchecked, games crash dolphin when booting now.

Actions #4

Updated by shadoweffex over 14 years ago

I can't reproduce this either, so it could be system or OS specific.

Actions #5

Updated by marcel.werner3 over 14 years ago

nope, I just tested a bit and it seems to be game specific. e.g. Mario Kart Wii, Dead
Space Ex., Mario Party 8, Fatal Frame 4, NSMB, etc.
Also CG: Z:TP, Mario Party 4, MP1&2, etc.

Well, maybe there are several factors shrug
Using Win7 64bit. recent dolphin revs 64bit.

Actions #6

Updated by glennricster over 14 years ago

I have this problem with Wii Big Brain Academy and the System Menu 4.2u also. I
actually reported this in issue 2038, but I didn't know at the time of reporting it
was being caused when the dual core option was unchecked.

I am using Ubuntu 9.10 linux 64bit and the latest dolphin revisions. This began on
the commit to revision 4854 if that helps.

Actions #7

Updated by BhaaL over 14 years ago

Issue 2038 has been merged into this issue.

Actions #8

Updated by Anonymous over 14 years ago

Issue 2106 has been merged into this issue.

Actions #9

Updated by glennricster over 14 years ago

Issue 2143 has been merged into this issue.

Actions #11

Updated by skidau over 14 years ago

I've narrowed down the problem to these routines: asm_routines.pairedStoreQuantized

I am not familiar with the SSE instruction-set and so I cannot debug it any further
than this.

The single core crash does not occur in Interpreter mode.

Actions #12

Updated by ayuanx over 14 years ago

BTW: single core crash doesn't occur on 32 Bit OS.

Actions #13

Updated by jacky.kk.tsui over 14 years ago

i'm running on win7 64bit .I have 7 games but only the game 'Arc Rise Fantasia' crashed
when single core is used .

Actions #14

Updated by sl1nk3.s over 14 years ago

so far, it only crashes on windows x64 (it seems like linux isn't affected either)
and it was introduced in r4854.

Actions #15

Updated by skidau over 14 years ago

glenric is using linux x64 and it happens to him (see comment above).

My guess is that there is a state problem involving the x64 registers between the
asm_routines.pairedStoreQuantized and the video plugin vertex loader. I cannot think
of any other reason why this might be happening under these circumstances.

Actions #16

Updated by jacky.kk.tsui over 14 years ago

i also tested it using dolphin 32bit version on 64 bit windows 7 and single core works
fine .Therefore , only 64 bit version running on 64 bit windows will crash .

Actions #17

Updated by skidau about 14 years ago

  • Issue type set to Bug
  • Category set to jit
  • Operating system N/A added
Actions #18

Updated by BhaaL about 14 years ago

Issue 2097 might be related after all?
Some testing revealed that the same patch as Sonic did for OSX (r4897) works, infact
with even less (only disabling LoadStorePaired does the trick).

Actions #19

Updated by tommyhl2.SS about 14 years ago

I'm still using R4869 as it is the fastest build for me and I can confirm this problem.

Win 7 X64.

Actions #20

Updated by nakeee about 14 years ago

@Jack can we disable it on 64 bit on coming release? or is it like major slow down?
(I would suggest even disabling it completely for all platforms...)

Actions #21

Updated by BhaaL about 14 years ago

nakee: Can't say anything about that, my reasoning was mainly based on observation of
experiences people had on Linux and OSX - I haven't got any crashes lately, on Win7
x64 with DC, not bothering to use SC when DC works.
Gonna see if I can find out other things about it, but I don't really know. I'd let
other people comment on it that tried out both things - crashing and working with the
patch in Issue 2097.

Actions #22

Updated by BhaaL about 14 years ago

Well, it at least seems to fix the SC Crash I get with Harvest Moon - Magical Melody;
other games work or dont make heavy use of Paired ops until where i checked.
I can't say whether setting bJITLoadStorePairedOff = true in general has any
noticeable impact on performance, since I don't have any comparable experiences with
it disabled.

How about
#ifdef _M_X64
if (!Core::g_StartupParameters.bCPUOnThread) { Default(inst; return; }
#endif
for psq_st and psq_l (both Jit and JitIL)?

Actions #23

Updated by skidau about 14 years ago

j4ck.fr0st, I agree with using that patch and putting a TODO comment in, so we
remember to come back to this one.

Actions #24

Updated by hrydgard about 14 years ago

Try now. I have doubts about my fix though.

Actions #25

Updated by hrydgard about 14 years ago

  • Status changed from New to Work started

I can't reproduce the problem, anyway. Someone with the problem, please list some games
that still crash, and mention your processor model.

Actions #26

Updated by skidau about 14 years ago

  • Status changed from Work started to Fixed

I believe this is fixed by r5062. One of the games that was crashing was Wii Sports.
It would crash before the strap screen appeared.

Actions #27

Updated by bigbeat99c about 14 years ago

Still crashing using single core on 64-bit r5063 on a Intel Core i7 920 HT enabled
with Windows 7 Ultimate 64-bit. This is an issue that needs to be fixed as some games
run poorly when dual core is enabled.

Actions #28

Updated by hrydgard about 14 years ago

Please, WHAT GAMES are crashing? I currently cannot reproduce it, and thus, I cannot
debug and fix it.

Actions #29

Updated by hrydgard about 14 years ago

  • Status changed from Fixed to Work started
Actions #30

Updated by jacky.kk.tsui about 14 years ago

one of the game i tested which will crash when using x64 + single core is Arc Risa
Fantasia JAP.

Actions #31

Updated by bigbeat99c about 14 years ago

Games I've tested to be crashing with single core:

Bomberman Land
Mario Kart Wii
NSMB
Wii Play
Wii Sports
Super Mario Galaxy
Zelda TP

Actions #32

Updated by BhaaL about 14 years ago

As mentioned earlier, Harvest Moon: Magical Melody also crashes (for me at least).

To add some more value to this issue, skid and i were discussing this on IRC
yesterday. It seems that the main problem is the vertex loader, which appearently
uses the same set of registers. With single core, those regs are shared, and a
context switch during a paired store will mess them up. Dual core doesnt have this
problem, since both run on separate threads.

I'm going to take a look into an earlier trace I had, since my crashes always showed
up inside the vertex manager, where address (being passed by reference) suddenly
became 0, while a stack further up it was non zero. Might turn out to be nothing of
worth at all, but thats my next thing to look into.

Actions #33

Updated by fjavier2k about 14 years ago

Wii music crashes with dual core option unchecked.

Actions #34

Updated by Anonymous about 14 years ago

Issue 2351 has been merged into this issue.

Actions #35

Updated by gitoshi about 14 years ago

sorry for the duplicate Issue 2351

this games crash

FIRE EMBLEM 10 EUR
Super Smash Bros Melee PAL
THE LEGEND OF ZELDA The Wind Waker for PAL
The Legend of Zelda Twilight Princess PAL
Fire Emblem: Path of Radiance PAL

here the crash with Software Render
Firma con problemas:
Nombre del evento de problema: APPCRASH
Nombre de la aplicación: Dolphin.exe
Versión de la aplicación: 0.0.0.0
Marca de tiempo de la aplicación: 4b7bc889
Nombre del módulo con errores: Plugin_VideoSW.dll
Versión del módulo con errores: 0.0.0.0
Marca de tiempo del módulo con errores: 4b7bc829
Código de excepción: c0000005
Desplazamiento de excepción: 000000000001b759
Versión del sistema operativo: 6.1.7600.2.0.0.256.1
Id. de configuración regional: 12298
Información adicional 1: 2dd0
Información adicional 2: 2dd0074caeaf918939a6e1a367cf135f
Información adicional 3: 8b25
Información adicional 4: 8b2521a20ba1aef0719c467b5fc55d23

here the crash with D3D Render
Firma con problemas:
Nombre del evento de problema: APPCRASH
Nombre de la aplicación: Dolphin.exe
Versión de la aplicación: 0.0.0.0
Marca de tiempo de la aplicación: 4b7bc889
Nombre del módulo con errores: Plugin_VideoDX9.dll
Versión del módulo con errores: 0.0.0.0
Marca de tiempo del módulo con errores: 4b7bc78b
Código de excepción: c0000005
Desplazamiento de excepción: 0000000000027e2f
Versión del sistema operativo: 6.1.7600.2.0.0.256.1
Id. de configuración regional: 12298
Información adicional 1: 2cc9
Información adicional 2: 2cc942495c51ae9a90d30bb5e6b8a8b4
Información adicional 3: 95e6
Información adicional 4: 95e6a671570a9123ffef77f6995c7cb4

here the crash with OGL Render
Firma con problemas:
Nombre del evento de problema: APPCRASH
Nombre de la aplicación: Dolphin.exe
Versión de la aplicación: 0.0.0.0
Marca de tiempo de la aplicación: 4b7bc889
Nombre del módulo con errores: Plugin_VideoOGL.dll
Versión del módulo con errores: 0.0.0.0
Marca de tiempo del módulo con errores: 4b7bc7f5
Código de excepción: c0000005
Desplazamiento de excepción: 000000000001a12f
Versión del sistema operativo: 6.1.7600.2.0.0.256.1
Id. de configuración regional: 12298
Información adicional 1: 277f
Información adicional 2: 277f00397efc6ad13004b4d1fb349011
Información adicional 3: 886b
Información adicional 4: 886bd50a52b1545f45112b479dc3a28b

my specs

Windows 7 x64 Spanish
Core 2 Duo E6750 @ 2.66
4 GB RAM DDR 800
Geforce GTX 275 896MB
Dolphin r5073

Actions #36

Updated by skidau about 14 years ago

  • Status changed from Work started to Fixed

This issue was closed by revision r5118.

Actions #37

Updated by nakeee about 14 years ago

Issue 2097 has been merged into this issue.

Actions #38

Updated by Theevillightbulb about 14 years ago

nakeee: linux still has this problem why did you merge the issue?

Actions

Also available in: Atom PDF