Project

General

Profile

Emulator Issues #2068

bloom is offset in d3d

Added by ebirnie almost 10 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
GFX
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

ive heard others talk about this issue in other games, but i think ive only
seen it in mario kart wii myself. the bloom glow is offset down and to the
right on everything (ghosts, karts/riders, cubes). best seen here on the
ghost level:

http://i.imgur.com/z2G0P.jpg


Related issues

Has duplicate Emulator - Emulator Issues #2654: EFB layer dimension is incorrect in DirectX pluginDuplicate

Has duplicate Emulator - Emulator Issues #3434: Some games are too blurry, wii play, SMG, MKwiiDuplicate

Has duplicate Emulator - Emulator Issues #3604: Donkey Kong Returns Display bug on world 2Duplicate

Has duplicate Emulator - Emulator Issues #3677: Halo on certain objects in Donkey Kong Country ReturnsDuplicate

Has duplicate Emulator - Emulator Issues #3968: Strange red/orange glow around everything in Donkey Kong Country ReturnsDuplicate

Has duplicate Emulator - Emulator Issues #3974: Resident Evil 4 bloom effect offsetDuplicate

Has duplicate Emulator - Emulator Issues #5018: Skyward Sword Cutscenes, All Revisions.Duplicate

History

#1 Updated by HeZkOrE almost 10 years ago

Same problem in Monster Hunter Tri and it's horrible in that, cause the bloom covers
pretty much the entire screen, not just single models :S

#2 Updated by john.fowler1541 almost 10 years ago

I concur this happens in dead space slightly down and to the right. see here
http://users.tpg.com.au/jfk//RZJE69-3.png

#3 Updated by HeZkOrE almost 10 years ago

Yeah check out Monster Hunter Tri: http://img23.imageshack.us/img23/7049/mhtri.png
It looks quite bad as the bloom covers the entire screen.

#4 Updated by jayork42 almost 10 years ago

Are you talking about EFB copy or the bloom shader in Dolphin? This also appears to
be the same problem NSMB is having in the sand/water worlds.

#5 Updated by ebirnie almost 10 years ago

ok i havent updated in a week or so, but i just did and noticed something. the bloom
offset has changed! look at this picture. its even more further to the right and
down. just gotta track down what did this and maybe it can be fixed?

http://i.imgur.com/NzIe7.png

#6 Updated by ebirnie almost 10 years ago

ok this may be helpful to the devs. i tracked down the revision that the bloom was
altered. it is r5034. heres an animation showing the bloom difference between r5033
and r5034. http://i50.tinypic.com/ztveih.gif

#7 Updated by HeZkOrE over 9 years ago

EFB Scaled Copy for DX9 has an impact on the Bloom, with it off the bloom moves even
further down the right, while with it on it's closer to the center.

#8 Updated by john.fowler1541 over 9 years ago

I've created a patch that helps this issue. You can find it here
http://forums.dolphin-emu.com/thread-8626.html

#9 Updated by marcel.werner3 over 9 years ago

this issue is still present...in quite some games (maybe even all games with bloom?). In Metroid 3 it's good to see, too.
Why hasn't this been accepted yet? I guess it should go to Rodolfo :)

#10 Updated by marcel.werner3 over 9 years ago

sooooooo it seems this issue only exists for nvidia users with both DX plugins...?

#11 Updated by giaga7 about 9 years ago

No, I've an Ati card 5870 and still have this error with mario kart wii, wii play (hockey), monster hunter tri!

#12 Updated by marcel.werner3 about 9 years ago

hmpf...why then does NeoBrain not have it? O_o
Could some dev please CC this to NeoBrain and Rodolfo? thx!

#13 Updated by hafizmml89 about 9 years ago

COrrect me if im worng, but i noticed if you use ?xSSSA options, the bloom offset effects is reduced right? I noticed it in MH3 when enabling 9xSSSA, the bloom is nearly perfect..... but not playable for me as it slowdowns the game ALOT!!!!! ( my gc card cannot handle 9xSSSA and strangely 4xSSSA too :( )

#15 Updated by giaga7 about 9 years ago

As I wrote in issue 3434 there also other games with this issue! For now, games with this issue are Mkwii, Mh3, Wii play and SMG! It woukd be great fixing this graphic issue! Some screenshots:

http://img839.imageshack.us/gal.php?g=rhap011.png

#16 Updated by skidau about 9 years ago

issue 3434 has been merged into this issue.

#17 Updated by skidau about 9 years ago

  • Category set to gfx

#18 Updated by marcel.werner3 about 9 years ago

Donkey Kong Country Returns also suffers from this issue. It's good to see here: http://img6.imageshack.us/img6/3672/donkeykongredglow2.png

#19 Updated by aavindraa about 9 years ago

Donkey Kong problem referred to above is discussed further in issue 3604.

#20 Updated by skidau about 9 years ago

issue 3604 has been merged into this issue.

#21 Updated by kolano about 9 years ago

This issue can be addressed, at least in DK Country Returns, by visiting the Wii Home screen and then returning to the game. It will reoccur in later stages however.

#22 Updated by marcel.werner3 about 9 years ago

huh? that's new to me...anyway, there is a projection hack that deals with it for now.
http://forums.dolphin-emulator.com/showthread.php?tid=13347

#23 Updated by NeoBrainX about 9 years ago

issue 3677 has been merged into this issue.

#24 Updated by Anonymous about 9 years ago

  • Status changed from New to Questionable

Please respond if this issue is still valid, or it will be closed.

#25 Updated by NeoBrainX about 9 years ago

  • Status changed from Questionable to Accepted

Still valid.

#26 Updated by giaga7 about 9 years ago

Still valid as NeoBrains said! in DKCR, MH3, MKwii, Wii play and I think others that I've not tested!

#27 Updated by NeoBrainX about 9 years ago

Fwiw, is this issue also present with DX11 in Mario Kart Wii for native EFB scaling?

There's numerous reasons for this issue I think: One being some off-by-one errors in our viewport/scissor rect code, the other one being in D3D9 that native HW uses floating points for viewports but D3D9 integers (which will cause some inaccuracy).

Also, I'm beginning to doubt whether this issue can be fixed at all for higher resolutions. We can't correctly upscale all viewport/scissor rect coordinates which f*cks up things quite a bit...

The bloom offset in MH3 can be fixed by enabling EFB access IIRC.

#28 Updated by NeoBrainX about 9 years ago

issue 2654 has been merged into this issue.

#29 Updated by marcel.werner3 about 9 years ago

hmhmhm...I just tried with DX11 and EFB scale set to 1x (and scaled copy disabled) - that would be native, right?
well, my findings are that in Mario Kart Wii it indeed is less strong...I'm actually not even sure if it's wrong at all...there's a bit of bloom looking over the edges but I cannot tell if that's an original effect to make things a bit more glowy...my Wii is broken so I can't test on that.
However, I also tested Little King's Story and there it doesn't seem to have changed.
Ah, btw. I made a screenshot in that game a few days ago cuz the issue is nicely well to see there (and that's even with "Skies of Arcadia"-proj hack enabled, normally it's even worse:

http://img577.imageshack.us/img577/7093/ro3exj1.png

#30 Updated by NeoBrainX almost 9 years ago

issue 3968 has been merged into this issue.

#31 Updated by skidau over 8 years ago

issue 3974 has been merged into this issue.

#32 Updated by skidau about 8 years ago

issue 5018 has been merged into this issue.

#33 Updated by dospant almost 8 years ago

I have been testing this with Monster Hunter mainly and here is what I noticed:. It is directly affected by the internal resolution.

The higher the internal resolution, the better the picture.
Enable Hotkeys and test this by playing with the "3" button which changes the internal resolution. You will notice that as you increase it, the effect gets closer and closer to where it should be. Currently 4x gives me the best image and the problem is almost gone but not entirely.

#34 Updated by danialhorton almost 8 years ago

heeeerrrrrrrrrrrrp derrrrrrrrrrrrp

#35 Updated by NeoBrainX almost 8 years ago

  • Status changed from Accepted to Fixed

This issue was closed by revision e58692653afd.

#36 Updated by NeoBrainX almost 8 years ago

Marking as fixed, since the main issue got fixed by revision e58692653afd.

Any other issues with blur should be reported separately now. Note that the blur in Monster Hunter Tri is fixed by enabling EFB access (since EFB color pokes are implemented now).

Also available in: Atom PDF