Project

General

Profile

Actions

Emulator Issues #2267

closed

When you chose to start game in fullscreen, first time you push ESC, the popup window doesn't have any border (everything is black)

Added by anthony.saunier over 14 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What steps will reproduce the problem?
1.open Dolphin and select to start a game in fullscreen in options (i use
Open GL too)
2.start a game
3.push ESC and you will see the awful popup (only the first time you push ESC)

What is the expected output? What do you see instead?
A good popup with borders
A awful popup without borders

Please use labels and text to provide additional information.

I have found the problem. This is how to solve it in the code:

The problem is in the ToggletoFullscreen method.

On line 500 of win32.cpp (plugin OGL), there is:

SetWindowPos(hParent, NULL, X, Y, rc.right-rc.left, rc.bottom-rc.top,
SWP_NOREPOSITION | SWP_NOZORDER);

// Set new window style FS -> Windowed
SetWindowLongPtr(hParent, GWL_STYLE, style);

INSTEAD OF THE RIGHT CODE (the lines must be inverted):

// Set new window style FS -> Windowed
SetWindowLongPtr(hParent, GWL_STYLE, WS_OVERLAPPEDWINDOW);
SetWindowPos(hParent, NULL, X, Y, rc.right-rc.left,
rc.bottom-rc.top, SWP_NOREPOSITION| SWP_NOZORDER);

Actions #1

Updated by ebirnie over 14 years ago

theres many issues with d3d right now when changing to and from full screen. i was
about to add a new issue for it but this is already here. i think this issue should
be one of those blocking a release issues until fixed.

Actions #2

Updated by anthony.saunier over 14 years ago

yep :)

Actions #3

Updated by ayuanx over 14 years ago

  • Status changed from New to Questionable

I can NOT reproduce this. WinXP32.

Actions #4

Updated by anthony.saunier over 14 years ago

Here is more information:

This problem happens with my laptop with ati mobility and the normal code i said but
not when the lines are inverted.

However, it does not happen on my computer at home with ati 4870 (changing the code
is useless).
I'm on win7 64.

Could it be a problem with graphics drivers or something else?

Actions #5

Updated by ayuanx over 14 years ago

I think so, actually if I revert the sequence I get black screen. Refer to R5025 and
you will see I made the sequence so purposely.

Actions #6

Updated by anthony.saunier over 14 years ago

Whoo Nice one ayuanx!!

Actions #7

Updated by Anonymous over 14 years ago

ayuanx: so is this fixed or not? :)

Actions #8

Updated by ebirnie over 14 years ago

this is a confirmed problem by me, and ive seen at least one other person on the irc
channel saying the same thing.

tho im not sure what popup and borders etc has to do with it, but if i run full
screen and hit esc it switches to windowed mode with a black screen. hitting play at
that point starts the SOUND back up but the video stays black.

Actions #9

Updated by ayuanx over 14 years ago

It is OS/Driver related, just as Comment 4 suggested.

Actions #10

Updated by ebirnie over 14 years ago

its not os/driver related, its related to the resolutions you choose for windowed and
fullscreen. like if you have 1360x768 for both windowed and fullscreen resolutions.
switching between them causes a black screen.
people with ati AND nvidia cards are having this problem.

Actions #11

Updated by luisr142004 over 14 years ago

still questionable? :P

Actions #12

Updated by NeoBrainX almost 14 years ago

Is this still an issue? (now that esc quits the game I can't reproduce it anymore, so...)

Actions #13

Updated by NeoBrainX almost 14 years ago

  • Status changed from Questionable to Fixed

Well.. whatever

Actions

Also available in: Atom PDF