Project

General

Profile

Actions
Copy link

Emulator Issues #2267

closed

When you chose to start game in fullscreen, first time you push ESC, the popup window doesn't have any border (everything is black)

Added by anthony.saunier almost 15 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What steps will reproduce the problem?
1.open Dolphin and select to start a game in fullscreen in options (i use
Open GL too)
2.start a game
3.push ESC and you will see the awful popup (only the first time you push ESC)

What is the expected output? What do you see instead?
A good popup with borders
A awful popup without borders

Please use labels and text to provide additional information.

I have found the problem. This is how to solve it in the code:

The problem is in the ToggletoFullscreen method.

On line 500 of win32.cpp (plugin OGL), there is:

SetWindowPos(hParent, NULL, X, Y, rc.right-rc.left, rc.bottom-rc.top,
SWP_NOREPOSITION | SWP_NOZORDER);

// Set new window style FS -> Windowed
SetWindowLongPtr(hParent, GWL_STYLE, style);

INSTEAD OF THE RIGHT CODE (the lines must be inverted):

// Set new window style FS -> Windowed
SetWindowLongPtr(hParent, GWL_STYLE, WS_OVERLAPPEDWINDOW);
SetWindowPos(hParent, NULL, X, Y, rc.right-rc.left,
rc.bottom-rc.top, SWP_NOREPOSITION| SWP_NOZORDER);

Actions
Copy link

Also available in: Atom PDF