Project

General

Profile

Emulator Issues #2500

Code Review Request - Widescreen Hack Tweak

Added by Billiard26 over 10 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
GFX
% Done:

0%

Operating system:
N/A
Issue type:
Feature request
Milestone:
Regression:
No
Relates to usability:
Yes
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Purpose of code changes on this branch:
Tweak the "Widescreen Hack":
- Hack longer assumes the game is running at 4:3 and the user has a
display of 16:9
- Attempt to adjust the aspect ratio From either 16:9 or 4:3 ( depending
on value of g_VideoInitialize.bAutoAspectIs16_9 )
- Attempt to adjust the aspect ratio To what the user has chosen in the
"Aspect Ratio" combobox.

[ Aspect Ratio combobox ] :
- If "Auto" is chosen, the hack will have NO effect in any game.
- If "Force 16:9" is chosen and a 4:3 game is running, the hack will
adjust from 4:3 to 16:9 (Hor+).
- If "Force 16:9" is chosen and a 16:9 game is running, the hack will have
NO effect.
- If "Force 4:3" is chosen and a 16:9 game is running, the hack will
adjust from 16:9 to 4:3 (Vert+).
- If "Force 4:3" is chosen and a 4:3 game is running, the hack will have
NO effect.
- If "Stretch" is chosen, the hack will adjust from the games aspect ratio
( either 16:9 or 4:3 ) to the aspect ratio of the user's chosen fullscreen
resolution. ( using Hor+ or Vert+ ) ( this allows playing of games on 16:10
or 5:4 displays without a fat or skinny 3d image )

After all, this is a "HACK". It should allow "Hacking" to any
aspect ratio the user wants. Not just 16:9.

When reviewing my code changes, please focus on:
I don't really care for the method I used to get the fullscreen resolution:
sscanf(g_Config.cFSResolution, "%dx%d", &w_fs, &h_fs);
I couldn't find a better/correct method. Maybe someone else can fix that.

Perhaps the entire "UpdateAspectRatioHack" function shouldn't be in
"VertexShaderManager.cpp". Maybe someone knows where it does belong.

Patch Download:
http://billiard.us.to/share/Dolphin/aspect_ratio_tweak.patch

History

#1 Updated by kevinx0404 over 10 years ago

do you have a compiled build to test? Seems interesting. i've been waiting for 16:10
resolution without being stretched for a while.

#3 Updated by kevinx0404 over 10 years ago

when using stretch, it stretches the image for 16:10 monitors, ie skinny.

#4 Updated by Billiard26 over 10 years ago

You have the widescreen hack box checked?

#5 Updated by kevinx0404 over 10 years ago

yes.

#6 Updated by Billiard26 over 10 years ago

What is your fullscreen resolution set to?

#7 Updated by kevinx0404 over 10 years ago

I set fullscreen to 1680*1050. Stretch=stretched image. stretched with widescreen
hack=no difference from stretch.

#8 Updated by Billiard26 over 10 years ago

Odd, what about setting it to force 4:3?

#9 Updated by kevinx0404 over 10 years ago

okay, I'm using dx9, force 4:3 wii setting 4:3 and widescreen hack on. With it on or
off, it makes no difference.

#10 Updated by Billiard26 over 10 years ago

With the wii set to 16:9 and widescreen hack on with force 16:9, it should have no
effect also.
Changing it to stretch and going fullscreen should make the image not appear skinny
or fat.
If you could go on irc and we could talk about what you are seeing that would be cool.

#11 Updated by kevinx0404 over 10 years ago

that'll have to wait to tomorrow. Sorry. I'll try to post pictures some other time.

#12 Updated by Billiard26 over 10 years ago

  • Status changed from New to Fixed

I fixed my code and committed it. :P

Also available in: Atom PDF