Project

General

Profile

Emulator Issues #261

Common.h is a mess

Added by Sonicadvance1 over 12 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
Yes
Regression start:
Fixed in:

Description

Common.h is a completely horrid mess and it needs to be cleaned up.

History

#1 Updated by Sonicadvance1 over 12 years ago

I don't wanna be the owner of this :P
Anyone who has time can clean it up.

#2 Updated by XTra.KrazzY over 12 years ago

  • Status changed from New to Questionable

It's not such a mess at all! :)

#3 Updated by omegadox over 12 years ago

It is a mess, it can cause simple C++ coding to break like the "<<" operater when you
do "cin << "x";" and if you try to concat 2 strings

#4 Updated by Anonymous over 12 years ago

what? are you using std::cin, std::string, etc?

#5 Updated by omegadox over 12 years ago

I was using the "<<" operater with ostringstream for some conversion.
And
std::string("Hello") + std::string(" World");

#6 Updated by nakeee over 12 years ago

  • Status changed from Questionable to Work started

look at r2201

#7 Updated by nakeee about 12 years ago

waiting for ector approval to merge

#8 Updated by nakeee about 12 years ago

  • Status changed from Work started to Fixed

Also available in: Atom PDF