Project

General

Profile

Actions

Emulator Issues #2670

closed

Scons does not honour PKG_CONFIG_PATH

Added by baffo32 almost 15 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What steps will reproduce the problem?

  1. Move system .pc files to a nonstandard dir such as ~/temppcs/
  2. In dolphin source tree:
    export PKG_CONFIG_PATH=~/temppcs/
    pkg-config --libs x11 # should still work
    scons # fails

Scons fails to find any system libraries via pkg-config.

PKG_CONFIG_PATH is an important environment variable when using pkg-config,
and scons only honours environment variables that are manually exported.
The attached patch does so.

Actions #1

Updated by nakeee almost 15 years ago

scons doesn't need to honor it, it just needs to pass it over to the call that runs
pkg-config from inside scons. But I remember that the import of the env suppose to do
that.

Actions #2

Updated by baffo32 almost 15 years ago

By 'honor' I mean pass it over to any process it runs. I tried scons 1.3.0 and 1.2.0
and in both only HOME and PATH were passed from my shell environment to pkg-config.
My environment is obviously not being entirely imported -- are you saying it should be?

Actions #3

Updated by baffo32 almost 15 years ago

Sorry, I understand -- the environment is imported elsewhere in the SConstruct. Here
is a proper patch.

Actions #4

Updated by nakeee almost 15 years ago

  • Status changed from New to Accepted

Much better but you need to check if the variable exists
your patch will make scons die if PKG_CONFIG_PATH is not set

Actions #5

Updated by nakeee almost 15 years ago

Can you try latest svn?

Actions #6

Updated by nakeee almost 15 years ago

  • Status changed from Accepted to Fixed

assumed fixed reopen if not

Actions

Also available in: Atom PDF