Project

General

Profile

Actions

Emulator Issues #3557

closed

OSX info.plist gives incorrectly-formatted version strings

Added by rcombs almost 14 years ago.

Status:
Won't fix
Priority:
Normal
Assignee:
-
Category:
Scripts
% Done:

0%

Operating system:
OS X
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What's the problem?
Currently, the machine-readable version string in info.plist includes the letter "M" (which it shouldn't), and the human-readable version string is "2.0" (it should be an actual human-readable version string [defining version 2.0 was sorta arbitrary, and real users want real version numbers.])

Dolphin version with the problem (as it appears in the title bar, Ex.: "R
4779" or "R 6403M"): Not really applicable, but 6477

(optional) Dolphin version that does not have the problem: None

Operating system and version: All OSX
32-bit or 64-bit: Both

Game ID (as it appears in game properties, Ex.: "GZ2P01" or "RSBE01"): N/A

Build command-line (not on Windows): Yep

Was the ISO a plain dump from disc, compressed and/or scrubbed? N/A

Please provide any additional information below.
I've got a patch!
http://pastebin.com/R3dHZnTy

Actions #1

Updated by soren.jorvang almost 14 years ago

  • Status changed from New to Won't fix
  • Category set to scripts
  • Operating system OS X added

There is no requirement that CFBundleShortVersionString be numeric dewey decimal only. It is basically the "user visible" version and as such, it reflects Dolphin's internal version numbering which uses svnversion and adds an M if the checkout is modified at all.

CFBundleVersion is the one used by OS X for things like document-application binding, which we don't currently do anything with, but it is set to the last release of Dolphin for good measure and will be set to 3.0 or whatever when we make the next release.

It is possible that it will also make sense to set CFBundleShortVersionString to 3.0 in the release build. Not sure yet. Not for trunk builds anyway.

References:
http://developer.apple.com/library/mac/#documentation/MacOSX/Conceptual/BPRuntimeConfig/000-Introduction/introduction.html
http://www.dribin.org/dave/blog/archives/2006/08/02/versioning_os_x_apps/

Actions

Also available in: Atom PDF