Project

General

Profile

Actions

Emulator Issues #3635

closed

File Handle Left Open Post ISO Decompression?

Added by kolano over 13 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What's the problem?
In some circumstances, Dolhin doesn't seem to release a GCZ file appropriately when it completes decompressing it. The file remains non-renamable/deletable until Dolphin is closed. The issue doesn't seem to happen consistently, possibly only for the first decompressed image.

Dolphin version with the problem (as it appears in the title bar, Ex.: "R
4779" or "R 6403M"): r6495

(optional) Dolphin version that does not have the problem: NA

Operating system and version: Windows 7 x64
32-bit or 64-bit: 64-bit

Game ID (as it appears in game properties, Ex.: "GZ2P01" or "RSBE01"):

Build command-line (not on Windows):

Was the ISO a plain dump from disc, compressed and/or scrubbed? Compressed

Please provide any additional information below.

Actions #1

Updated by kolano over 13 years ago

It's not just for the first decompressed image.

Actions #2

Updated by tommyhl2.SS over 13 years ago

I've compressed many games with r6500 and have not come across this problem ever. I'm on Win7 32-Bit.

Actions #3

Updated by kolano over 13 years ago

The bug is with decompressing games not compressing them.

Actions #4

Updated by kolano over 13 years ago

Also, per my original comment, I can't get it to occur consistently. It was occurring for each file I decompressed when I reported this, though I'm having trouble reproducing the issue now.

Some other possibly relevant details...
-Files were decompressed to a different drive than the GCZ files were originally stored on
-The GCZ files were stored on a NAS and accessed in Dolphin via a mapped drive

Actions #5

Updated by Anonymous over 13 years ago

http://code.google.com/p/dolphin-emu/source/browse/trunk/Source/Core/DiscIO/Src/CompressedBlob.cpp#300
decompressing is pretty simple, and fclose() is always called, if fopen() succeeded...so the problem doesn't appear to be obvious...

Actions #6

Updated by Anonymous over 13 years ago

oh actually you're talking about the gcz? In that case, the delete reader; line should be releasing the handle...still not too obvious.

Actions #7

Updated by Billiard26 about 13 years ago

Does r7328 fix this issue?

Actions #8

Updated by kolano about 13 years ago

I'm unable to get it to re-occur with r7328. Unfortunately, since it only occurred sporadically previously I can't guarantee it's addressed.

Actions #9

Updated by Billiard26 about 13 years ago

  • Status changed from New to Fixed

Assuming fixed.

Actions

Also available in: Atom PDF