Project

General

Profile

Actions

Emulator Issues #378

closed

Blurry square in left upper corner Wii Sports - needs stretching.

Added by absynt777 over 15 years ago. Updated over 5 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
GFX
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What steps will reproduce the problem?

  1. Load the game
  2. Choose boxing, tenis or baseball.
  3. While playing you can see blurred square on 1/4 of the image.

What version of the product are you using? On what operating system?
Vista Ultimate x64
Rev 1405

Please provide any additional information below.
I think that stretching this blurry part can help. Although this part is
stretched in cutscenes.

Some screens:
http://img241.imageshack.us/my.php?image=59473313dy1.jpg
http://img508.imageshack.us/my.php?image=68469317iu0.jpg

In "choose game" menu there is another problem. It's invisible. You must
somehow choose game, clik back (return to the menu) and menu would be visible.


Files

DxDiag.txt (69.6 KB) DxDiag.txt System info gembrot, 11/30/2018 10:09 AM
Dolphin.ini (4.06 KB) Dolphin.ini gembrot, 11/30/2018 10:22 AM
Actions #1

Updated by Sonicadvance1 over 15 years ago

This is the same as Zelda Twilight princess
Using 640x480 should fix it.

Actions #2

Updated by absynt777 over 15 years ago

Nope, this square is always 1/4 of display on each resolution.

Actions #3

Updated by slink_3_ over 15 years ago

just like twilight princess, it always take 1/4 of the display, and bloom is
misplaced, disabling copy EFB to texture remove these glitches, but also removes the
HUD and some others effect :(

Actions #4

Updated by slink_3_ over 15 years ago

Huh, I think I've found something !

in OpenGL plugin's TextureMngr.cpp from line 375 to 376
there's two lines :

int w = (abs(source->right-source->left)/mult+7)&~7;
int h = (abs(source->bottom-source->top)/mult+7)&~7;

changing that to :

int w = (abs(source->right-source->left)/mult);
int h = (abs(source->bottom-source->top)/mult);

Fix the bloom offset in games like Twilight princess and also fix the offset that you
can see in the 'blurry square' of Wii Sport so it looks good now, also, in native
res, the blurry box can't be seen, as it doesn't blur anything, and is no longer
ofsetting, but I've yet to find any way to fix its scaling however...

(P.S: this was quite unexpected fix :p, and if anyone can explain me how this '&~x'
thing works, it'd be nice, I actually removed it cause I couldn't find any doc
explaining that.. :D and it turned out better :p)

Actions #5

Updated by absynt777 over 15 years ago

Nice job! :D
Could you send mi Revision with these 2 lines changed or only OGL plugin?
I would like to see how it looks like now.
Really, you deserve for a big cold beer ^^

Actions #6

Updated by slink_3_ over 15 years ago

you can find a couple of screens (and OGL plugin too) in this post :D :
http://forums.ngemu.com/dolphin-discussion/107877-dolphin-svn-shots-48.html#post1532129

Actions #7

Updated by ChaosCode over 15 years ago

nice fix, Ill test and get it submitted tonight. this might fix mario kart wii as
well :D

Actions #8

Updated by Anonymous over 15 years ago

  • Status changed from New to Accepted

slink_3_, &~X means bitwise AND the bitwise NOT of X.
given:
X = 7 = 0b0111
and some random number for simple example:
10 = 0b1010

0b1010 & ~0b0111 =
0b1010 & 0b1000 = 0b1000 = 8

I haven't looked at this section of the code before, I have no idea why it's there.
(going to test this change now)

Actions #9

Updated by Anonymous over 15 years ago

looks great, omegadox commited it. if you want svn write, just send an email to
hydgard or F|RES, or otherwise contact them somehow ;)

Actions #10

Updated by slink_3_ over 15 years ago

alright,
thanks for the explanation :)

Actions #11

Updated by Anonymous over 14 years ago

  • Status changed from Accepted to New

It's back (did it ever really go away?!)
You can see it mostly in nintendo-made games:
wii sports
z:tp
..+others?

Just gonna....um, go ahead and mark this as "new"

Actions #12

Updated by KrossX3 over 14 years ago

Is still present in 4418 even with the Software plugin.

Zelda TP - Soft plugin
http://img42.imageshack.us/img42/6830/softfm.jpg
( Issue #1443 -> #828 can also be seen present )

Actions #13

Updated by Anonymous over 14 years ago

  • Category set to gfx
Actions #14

Updated by daws72 over 14 years ago

Still present in later revision r4656.
Here some more info:
http://daws.ngi.it/dolphin/RSPP01-2.jpg no problem in menu.

http://daws.ngi.it/dolphin/RSPP01-3.jpg
http://daws.ngi.it/dolphin/RSPP01-4.jpg
problem on upper left corner, exactly 1/4 of the screen. The image in this area looks
no scaled to upper resolution, like the remaining of the area.

Actions #15

Updated by daws72 over 14 years ago

BTW using D3D. No problem in OGL

Actions #16

Updated by KrossX3 over 14 years ago

As of rev4800 I can still see the blurry square in Zelda:TP, in both DX9 and OGL.

http://img410.imageshack.us/img410/958/4800ogl.jpg
http://img297.imageshack.us/img297/9111/4800dx9.jpg

Using ATI 5770 with Catalyst 9.12.

Actions #17

Updated by KrossX3 over 14 years ago

The link to the OGL one doesn't seem to work, so here's a new one:

http://img171.imageshack.us/img171/958/4800ogl.jpg

Actions #18

Updated by lordreyiss about 14 years ago

a simple work around to offset box (in Twilight Princess at least) is to use free look
(opengl plugin/advanced/select free look) press S 2 times and the box goes away along
with the bright yellow around the bottom of the screen. This has to be done on every
play through. Basically it just zooms out the camera 2 steps which for some reason
fixes it.

Actions #19

Updated by skidau over 13 years ago

  • Status changed from New to Fixed

I couldn't reproduce this issue anymore (r6360).

Updated by gembrot over 5 years ago

Regression: this issue re-appeared when using the development binaries when running Mario Kart Wii on Intel HD 2000 (Core i3 2100 IGP) and default graphics settings.

The fix mentioned above to disable copy EFB to texture doen't work (it just make things a bit more sluggish)
In its own window or fullscreen in 640x480 doesn't fix it either.

The current stable doesn't have the issue but those development version do:
dolphin-master-5.0-9166-x64 (today)
dolphin-master-5.0-9149-x64 (yesterday)
dolphin-master-5.0-8299-x64 (5 month old)
dolphin-master-5.0-7888-x64 (6 months ago)

I've attached the output from dxdiag and the dolphin.ini I'm using.

https://i.imgur.com/QwhJAqv.png

Actions #21

Updated by JMC4789 over 5 years ago

These issues are not related whatsoever.

Anyway, since you're here, I can more or less explain the situation. The reason your graphics card does not support the minimum requirements for the new LogicsOp code. In order to get correct behavior on supported devices, the old hack was removed, meaning that outdated drivers/graphics cards have issues. You can use another backend, older builds, or maintain the hack yourself on a fork. We don't like maintaining old hacks because it increases code complexity and makes it harder for new features to be added. Sometimes this can be frustrating for people on older computers/operating systems, but, in order to keep getting emulation better overall, it has to be done.

Actions #22

Updated by gembrot over 5 years ago

Created bug #11466 to address this issue.

Actions

Also available in: Atom PDF