Project

General

Profile

Emulator Issues #4064

AVI dumping assumes constant frame rate

Added by smelenchuk over 9 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

AVI dumping assumes a constant (60fps on Windows, 30fps on other platforms) frame rate. For games where the frame rate changes (e.g. Twilight Princess shifts from 60fps to 30fps just after the warning screen and logos), this results in a video which does not match real time playback and doesn't match up with sound dumps (as provided by my own patch).

Fixing this would be a prerequisite to getting synced AVI/sound dumps and, later, AVI-with-sound dumping.

First noticed with r7058, but it's likely that older version share this issue.

History

#1 Updated by smelenchuk over 9 years ago

I can think of two approaches to fixing this:

1) Have AddFrame trigger on a VI as opposed to a new frame being rendered; or

2) Have the AVI split on detecting a new target frame rate.

Considering AVIDump::AddFrame is called from the video plugins' Render function, 1) would require some reworking of where it's called. 2) would require info on what frame rate the game is running at.

#2 Updated by smelenchuk over 9 years ago

The attached patch dumps frames on every VI. (It also selects the output frame rate based on NTSC/PAL properly.)

See also http://forums.dolphin-emulator.com/showthread.php?tid=15036

#3 Updated by jayork42 over 9 years ago

Smelen is this patch, as well as the audio one pubicly available in built form yet? Would love to do some testing.

#4 Updated by smelenchuk over 9 years ago

  • Status changed from New to Fixed

This issue was closed by revision r7131.

#5 Updated by William79371 over 9 years ago

Thanks!!!

Also available in: Atom PDF