Project

General

Profile

Actions

Emulator Issues #4097

closed

Frame Skipping on Mac OS X (since about R7165 or earlier)

Added by louis.farnham over 13 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What's the problem?

Frame skipping causes video output to stall (no more frames FPS=0, everything else changes as if emulating correctly), though it continues emulation in the background.

Dolphin version with the problem (as it appears in the title bar, Ex.: "R
4779" or "R 6403M"):

R7170

(optional) Dolphin version that does not have the problem:

It's about 10 to 15 ago, I can track down if required.

Operating system and version:
32-bit or 64-bit:

Mac OS X 10.6.6 (64-bit)

Game ID (as it appears in game properties, Ex.: "GZ2P01" or "RSBE01"):

Any (have tested SMS, SMG2, RE4 so far)

Build command-line (not on Windows):

Unsure, but I'm getting them from:
http://dolphinemulatormac.dyndns.org/

Was the ISO a plain dump from disc, compressed and/or scrubbed?

Mainly plain dumps

Please provide any additional information below.

Tried all frame skipping (1 to 9).


Related issues 1 (0 open1 closed)

Has duplicate Emulator - Emulator Issues #4770: Frame Skipping doesn't work on MAC OSX LionDuplicate

Actions
Actions #1

Updated by louis.farnham over 13 years ago

Just tried FPS for limiting on/off - as per below, same deal.

http://forums.dolphin-emulator.com/showthread.php?tid=15117&highlight=frame+skip

Actions #2

Updated by soren.jorvang over 13 years ago

  • Status changed from New to Accepted
Actions #3

Updated by skidau over 13 years ago

Although r7128 changed the frameskip logic, it would only take effect when you are "Starting recording" or "Play recording". Please determine the exact revision when this issue started occurring.

Actions #4

Updated by louis.farnham over 13 years ago

OK got it working in R7125, just going rev-by-rev to see where it got broke...

Actions #5

Updated by louis.farnham over 13 years ago

It's inbetween 7135 and 7140, just narrowing down now...

Actions #6

Updated by louis.farnham over 13 years ago

Well the website above I'm using to pull the Mac builds misses out 7136-7137, so I can't test those.

Suffice to say, it frame skipping works in 7135, but is broken in 7138.
Hope that's enough to find out what's caused it.

Actions #8

Updated by louis.farnham over 13 years ago

Issue still present on R7184

Actions #9

Updated by lpfaint99 over 13 years ago

  • Operating system OS X added
Actions #10

Updated by louis.farnham over 13 years ago

As of R7202 I've tried every option in Graphics plugin on/off and a load of different combinations (though not every single possibility clearly), and same deal - frame skipping causes video output to freeze.

Actions #11

Updated by SchickeNipple about 13 years ago

Same issue here: As soon as frame skipping is enabled in Mac OS Lion, the video freezes, but the game runs faster in the background

Actions #12

Updated by NeoBrainX about 13 years ago

Issue 4770 has been merged into this issue.

Actions #13

Updated by benjamin about 13 years ago

when is this going to be fixed cos it's been going on for a wile so I am stuck to using old versions of dolphin instead to new ones which are better.

Actions #14

Updated by NullSolaris about 13 years ago

I would like to also confirm this is not only Mac specific, on Ubuntu (10.04), frameskip stops video rendering, but the rest of the game works.

Actions #15

Updated by benjamin almost 13 years ago

This issue has been going on for nearly a year please could the dolphin team fix it. There are a lat of mac uses and most of us are stuck with old versions or having to play the game really slowly because they don't have a high end mac. So please could someone fix this issue.

Actions #16

Updated by dubois.damien almost 13 years ago

is this problem has been fixed recently ?

I experience the same issue.
OSX 10.6.8
Dolphin 3.0 368
macbook pro intel core duo 2.16 2Go RAM

When switching to frame skipping > 9 speed is 100% but frozen on a still frame.
Switching to 1 to 9 same issue with lower speed.

It would be so nice to fix this ;)

Regards

Actions #17

Updated by parlane almost 13 years ago

  • Operating system N/A added
Actions #18

Updated by benjamin over 12 years ago

What does (No comment was entered for this change.) mean??

Actions #19

Updated by parlane over 12 years ago

Means I changed the issue details, but did not make a comment. "Labels: OpSys-Linux" showed what I did.

Actions #20

Updated by levity over 12 years ago

Still happening on 3.0-421, Lion, Macbook Air Core i7 (Intel HD3000 graphics).

Actions #21

Updated by UraharaKisuke153 over 12 years ago

I had this issue on Debian 64-bit until I built with libav support.

Actions #22

Updated by plbl4ster about 12 years ago

I think this bug was introduced in r7135. A change was made in that revision:

--- a/Source/Plugins/Plugin_VideoOGL/Src/Render.cpp
+++ b/Source/Plugins/Plugin_VideoOGL/Src/Render.cpp
@@ -964,11 +966,11 @@ void Renderer::Swap(u32 xfbAddr, FieldType field, u32 fbWidth, u32 fbHeight,cons
if (g_bSkipCurrentFrame || (!XFBWrited && (!g_ActiveConfig.bUseXFB || !g_ActiveConfig.bUseRealXFB)) || !fbWidth || !fbHeight)
{
if (g_ActiveConfig.bDumpFrames && data)
#ifdef _WIN32
AVIDump::AddFrame((char *) data);

  •    #else
    
  •    #elif defined HAVE_LIBAV
           AVIDump::AddFrame(data);
       #endif
       Core::Callback_VideoCopiedToXFB(false);
       return;
    
    }

See what happens if neither _WIN32 nor HAVE_LIBAV is defined:

if (g_ActiveConfig.bDumpFrames && data)
Core::Callback_VideoCopiedToXFB(false);

Probably not what the author intended. I edited this file (Source/Plugins/Plugin_VideoOGL/Src/Render.cpp) and just added braces:

if (g_ActiveConfig.bDumpFrames && data)
{
#ifdef _WIN32
AVIDump::AddFrame((char *) data);
#elif defined HAVE_LIBAV
AVIDump::AddFrame(data, w, h);
#endif
}
Core::Callback_VideoCopiedToXFB(false);

There are two places in this file where it needs to be done. After recompiling, I no longer get this bug.

Actions #23

Updated by delroth about 12 years ago

Nice find! Adding braces should indeed fix that issue. I'll commit that change with author name "plbl4ster ", is that ok with you?

Actions #24

Updated by plbl4ster about 12 years ago

Yes, that's fine with me.

Actions #25

Updated by delroth about 12 years ago

  • Status changed from Accepted to Fixed

This issue was closed by revision 94e49c50440f.

Actions #26

Updated by louis.farnham about 12 years ago

Woohoo! Only took a year or two, but congrats on the awesome find! Thank
you!!

On Tuesday, August 28, 2012, wrote:

Actions

Also available in: Atom PDF