Project

General

Profile

Actions

Emulator Issues #4267

closed

Disable DSP LLE engine options if DSP dumps cannot be found

Added by NeoBrainX over 13 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
UI
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What steps will reproduce the problem?

  1. Select DSP LLE recompiler or interpreter in the audio config without having the necessary DSP dumps inside the user directory
  2. Start a game

What is the expected output? What do you see instead?
Dolphin initializes its core using DSP LLE and of course fails doing so. This could be anticipated by just disabling the LLE options in the audio config.

Of course, there still needs to be a way to inform the user why the options are disabled. With a more informative label explaining this, we might even be able to stop noobs from spamming the forums with questions about why LLE won't work as well.


Related issues 1 (0 open1 closed)

Blocks Emulator - Emulator Issues #4270: Dolphin 3.0 bug trackerFixedNeoBrainX

Actions
Actions #1

Updated by nakeee over 13 years ago

I think we should make HLE as fall back, so LLE will be default if those files exists.

Actions #2

Updated by skidau over 13 years ago

yeh, I agree with nakeee.

Actions #3

Updated by Billiard26 over 13 years ago

I don't think LLE should be default, even if the files exist.
It's slower, just because I have the files doesn't mean I want to use DSP LLE every run.

Actions #4

Updated by Billiard26 over 13 years ago

  • Status changed from New to Fixed

I say fixed by r7426 :p

Actions #5

Updated by NeoBrainX over 13 years ago

  • Status changed from Fixed to Accepted

Erm, no...

Actions #6

Updated by nakeee over 13 years ago

You have a better idea on how to fix it?
Just disabling the box will confuse people. Not to mention it
wont account for bad inis.
I think that billard's solution sounds reasonable enough

Actions #7

Updated by NeoBrainX over 13 years ago

I'd just disable the LLE options and add some label telling them they need to have LLE dumps in place to select them. If someone hacks his config to use LLE, he prolly knows what he's doing anyway (altho we still have the popup then)..

Actions #8

Updated by NeoBrainX over 13 years ago

  • Status changed from Accepted to Won't fix

ok, nevermind.. consensus on IRC was that the current method (with a more descriptive error message) is enough. Guess I'm fine with that, it's better than nothing.

Actions #9

Updated by JMC4789 about 11 years ago

  • Status changed from Won't fix to Fixed

Fixed since Dolphin has its own LLE files included with the emulator now.

Actions

Also available in: Atom PDF