Project

General

Profile

Emulator Issues #4310

DX11: Line primitives drawn with incorrect width

Added by Nolan.Check about 10 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What steps will reproduce the problem?
1. Use the DX11 backend on any game that uses line primitives. This problem is most noticeable on the Twilight Princess map.

What is the expected output? What do you see instead?
Lines are drawn with incorrect width, so the map looks wrong. The lines are so skinny that they become invisible on the low-res map.

Dolphin version with the problem? Other Dolphin version without the
problem?
Since r7340 (my commit to add line and point primitives to DX11 backend)

32-bit or 64-bit and any other build parameters?
Any Windows build

OS version and versions of tools/libraries used?
Any version of Windows with DX11 support

Please provide any additional information below.
I know what the problem is and how to fix it, but I can't work on it this week because it's spring break. I'm making this report to remind myself of what needs to be done, or possibly for another developer to take care of.

The line and point geometry shaders are assuming a viewport size of 640x528. This is incorrect. The viewport can be adjusted by the game, but the line width and point size are still specified in pixels. The shaders need to compensate for this.

History

#1 Updated by Nolan.Check about 10 years ago

  • Status changed from New to Fixed

Should be fixed with r7418.

Also available in: Atom PDF