Project

General

Profile

Emulator Issues #4390

Dialog button spacing is inconsistent

Added by Billiard26 over 9 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
Category:
UI
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Many of the dialogs (GCPad, Wiimote, VideoConfig) have different amounts of spacing between and above the lower buttons. (OK/Cancel buttons)

This spacing should be consistent across all of Dolphin.

We should decide on how much spacing we want and use it everywhere.


Related issues

Blocks Emulator - Emulator Issues #4270: Dolphin 3.0 bug trackerFixed

History

#2 Updated by glennricster over 9 years ago

Most likely we should not mess with spacing at all. Rather we should use the default wxWidget spacing for everything. The reason for this is that the spacing is different on all platforms, and changes even on a specific platform if translations are used. The wxDefault... is designed to handle everything, so use that. Yes, sometimes this is not the prettiest at times, but that is the proper way to do this.

#3 Updated by glennricster over 9 years ago

Oh, wait you are just talking about above/below the dialog ok/cancel buttons. That is okay to configure.

#5 Updated by NeoBrainX over 9 years ago

Seems to work pretty nicely, working on it ;)

#6 Updated by glennricster over 9 years ago

NeoBrainX: Many of the dialogs are already using that. I recently switched many of them to use wxDialog::CreateButtonSizer which uses the wxStdDialogButtonSizer internally.

#7 Updated by NeoBrainX over 9 years ago

oh, didn't know that we were already using that.
At least the video config dialog doesn't use it, yet. So this issue just boils down to finding the remaining dialogs which don't use wxStdDialogSizer, yet :P

#8 Updated by NeoBrainX over 9 years ago

  • Status changed from New to Fixed

Also available in: Atom PDF