Emulator Issues #4390
closed
Dialog button spacing is inconsistent
0%
Description
Many of the dialogs (GCPad, Wiimote, VideoConfig) have different amounts of spacing between and above the lower buttons. (OK/Cancel buttons)
This spacing should be consistent across all of Dolphin.
We should decide on how much spacing we want and use it everywhere.
Updated by glennricster over 13 years ago
Most likely we should not mess with spacing at all. Rather we should use the default wxWidget spacing for everything. The reason for this is that the spacing is different on all platforms, and changes even on a specific platform if translations are used. The wxDefault... is designed to handle everything, so use that. Yes, sometimes this is not the prettiest at times, but that is the proper way to do this.
Updated by glennricster over 13 years ago
Oh, wait you are just talking about above/below the dialog ok/cancel buttons. That is okay to configure.
Updated by NeoBrainX over 13 years ago
You might probably want to look into http://docs.wxwidgets.org/2.8/wx_wxstddialogbuttonsizer.html#wxstddialogbuttonsizer ;)
Updated by NeoBrainX over 13 years ago
Seems to work pretty nicely, working on it ;)
Updated by glennricster over 13 years ago
NeoBrainX: Many of the dialogs are already using that. I recently switched many of them to use wxDialog::CreateButtonSizer which uses the wxStdDialogButtonSizer internally.
Updated by NeoBrainX over 13 years ago
oh, didn't know that we were already using that.
At least the video config dialog doesn't use it, yet. So this issue just boils down to finding the remaining dialogs which don't use wxStdDialogSizer, yet :P