Project

General

Profile

Actions

Emulator Issues #4401

closed

Changing between open gl and dx9 backend sets post processing shaders of opengl to off instead of default in the game ini.

Added by kostamarino over 13 years ago.

Status:
Invalid
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What's the problem?
Changing between open gl and dx9 backend sets post processing shaders of opengl to off instead of default in the game ini. This overrides the general option of open gl for that specific game.

Dolphin version with the problem (as it appears in the title bar, Ex.: "R
4779" or "R 6403M"):
r7459

(optional) Dolphin version that does not have the problem:

Operating system and version:
32-bit or 64-bit:
64 bit windows 7
Game ID (as it appears in game properties, Ex.: "GZ2P01" or "RSBE01"):

Build command-line (not on Windows):

Was the ISO a plain dump from disc, compressed and/or scrubbed?

Please provide any additional information below.

When you use open gl and run a game the below lines are created in the game ini after you open the settings.

[Video_Enhancements]
PostProcessingShader =

Then switch to direct 3d 9 and run the same game. Open the settings window. The above lines will change to:

[Video_Enhancements]
PostProcessingShader = off

Now if you change to open gl and enable a post processing shader in the general settings it will not apply to this game since it is set to off in it's ini.

Actions #1

Updated by gnick79 over 13 years ago

@kosta

I tried to simulate this bug with the GUI; but for me is impossible until I put "PostProcessingShader = " inside the INI manually.

Thus, the question is:
Does it exist a circumstance where "PostProcessingShader = " is stored? The algorithm should be to remove completely the key when it's empty.

Actions #2

Updated by kostamarino over 13 years ago

Nevermind gnick, it is a database issue then, as that line was created by the previous implementation of per game settings and the database was updated.
See the ini files here:
http://code.google.com/p/dolphin-cheats-database/source/detail?r=311
I guess i will have to update it by deleting all those lines.

Actions #3

Updated by MofoMan2000 over 13 years ago

When using the DX9 or DX11 plugins, neither one of those should TOUCH the postprocessing shader setting at all, since they don't use it. In fact, is there any good reason to have that option in an INI in the first place? Shaders have their own repository which any given person may or may not have updated, and if it's ever set in the cheats database files for whatever reason, there may be problems.

Actions #4

Updated by gnick79 over 13 years ago

  • Status changed from New to Invalid
Actions

Also available in: Atom PDF