Emulator Issues #4452: DSP HLE has various instances of producing the wrong and/or no output - Emulator - Dolphin bug tracker

I hope that this is not kind of a trash one.
Although I understand that LLE will be better than HLE, I must remind devs that not all people can have the dumped files of dsp (far from easy to get those).

Actions

Copy link

#32

Updated by LM1234 over 13 years ago

Issue 2200 has been merged into this issue.

Actions

Copy link

#33

Updated by chiizufish over 13 years ago

I found a fix for the issue I was having in Super Mario Sunshine with the DSP HLE in Issue 4437.

Half-nibbles weren't being masked correctly, and the final shift for AFC type 5 seemed to be wrong. (The fix was derived from SMS's ucode, rather than being a stab in the dark, so hopefully it won't break other things; though I was unable to test any other games.)

Attached is a patch for "UCode_Zelda_ADPCM.cpp".

Actions

Copy link

#34

Updated by Anonymous over 13 years ago

chiizufish: sounds nice :)
If you'd like svn access you can send a mail to hrydgard, else someone else can commit it for you.

Actions

Copy link

#35

Updated by hrydgard over 13 years ago

chiizufish: Nice patch. You've been added as a committer, go right ahead!

Actions

Copy link

#36

Updated by hrydgard over 13 years ago

Status changed from New to Work started

Actions

Copy link

#37

Updated by Anonymous over 13 years ago

Issue 2472 has been merged into this issue.

Actions

Copy link

#38

Updated by irencepn over 13 years ago

1000000 thanks for start working on this issue(s).

Ive tested game Resident Evil Remake (issue 3485 - merged into 1539 - merged in this).
Its not fixed, but ive noticed small difference (dunno is it related to this patch or emulation). Check uploaded mp3's

DSP HLE without patch:

http://www.mediafire.com/?n16ti577313kbst

DSP HLE with patch:

http://www.mediafire.com/?c4my5rnc7gbien3

DSP LLE without patch (same is with patch too, cuz with LLE 50% fps drop occurs after few seconds on save room, in the rest rooms music is fine - except in save room):

http://www.mediafire.com/?6se3rhft75th9z1

This is how should it be:

http://www.mediafire.com/?aa1km7qk0agdzc8

Thanks and good luck with your work.

Actions

Copy link

#39

Updated by Anonymous over 13 years ago

Issue 3184 has been merged into this issue.

Actions

Copy link

#40

Updated by xLunarSagex over 13 years ago

Skies of Arcadia's music is still messed up but it improved after the Super Mario Sunshine fix. I can't exactly pinpoint it but its like there are not enough audio channels or something for each note? The notes sounds like they are cut off. Thanks Dolphin Team! =)

Actions

Copy link

#41

Updated by Anonymous over 13 years ago

Issue 4482 has been merged into this issue.

Actions

Copy link

#42

Updated by tommyhl2.SS over 13 years ago

Get yourself a copy of Mario Superstar Baseball for the GC and load it with HLE, you'll get an instant head-ache. LLE is fine. This game is a good example of what may be wrong with some games.

Actions

Copy link

#43

Updated by LM1234 over 13 years ago

Issue 4491 has been merged into this issue.

Actions

Copy link

#44

Updated by LM1234 over 13 years ago

Issue 1861 has been merged into this issue.

Actions

Copy link

#45

Updated by LM1234 over 13 years ago

Issue 4501 has been merged into this issue.

Actions

Copy link

#46

Updated by LM1234 over 13 years ago

Issue 4552 has been merged into this issue.

Actions

Copy link

#47

Updated by irencepn over 13 years ago

Any progress with this issue(s) ?

Actions

Copy link

#48

Updated by NeoBrainX over 13 years ago

No. And please stop asking instead of spamming all CC'ed people, you'd see the progress in the commmit logs if there was any.

Actions

Copy link

#49

Updated by LM1234 over 13 years ago

Issue 4620 has been merged into this issue.

Actions

Copy link

#50

Updated by LM1234 over 13 years ago

Issue 4623 has been merged into this issue.

Actions

Copy link

#51

Updated by LM1234 over 13 years ago

Issue 4624 has been merged into this issue.

Actions

Copy link

#52

Updated by LM1234 over 13 years ago

Issue 4621 has been merged into this issue.

Actions

Copy link

#53

Updated by LM1234 over 13 years ago

Issue 4643 has been merged into this issue.

Actions

Copy link

#54

Updated by LM1234 over 13 years ago

Issue 4563 has been merged into this issue.

Actions

Copy link

#55

Updated by LM1234 over 13 years ago

Issue 4230 has been merged into this issue.

Actions

Copy link

#56

Updated by LM1234 over 13 years ago

Issue 4669 has been merged into this issue.

Actions

Copy link

#57

Updated by LM1234 over 13 years ago

Issue 4685 has been merged into this issue.

Actions

Copy link

#58

Updated by LM1234 over 13 years ago

Issue 4687 has been merged into this issue.

Actions

Copy link

#59

Updated by soren121 over 13 years ago

Seeing how many issues are merged into this one, don't you think it should have a higher priority than Low?

Actions

Copy link

#60

Updated by NeoBrainX over 13 years ago

That would mean that this issue actually has a high priority though, which it hasn't.

Actions

Copy link

#61

Updated by gabrielmorano over 13 years ago

I do think it's an important issue, but it's not that important as the fifo ones for example...

so it's not higher than than that kind of issues (that makes emulation crash or not possible) but i do think that low... is under the category, as HLE is way faster than LLE... so it's actually something to take in consideration

Actions

Copy link

#62

Updated by MofoMan2000 over 13 years ago

I'll have to agree. LLE is still much slower on somewhat-powerful Core2 systems. Only those with i7s see little to no performance loss with LLE. HLE may never be as accurate as LLE but it sure as hell shouldn't be abandoned, or shoved into the low-priority corner of the bug tracker.

Actions

Copy link

#63

Updated by carlos.ismael.braz over 13 years ago

This issue should have a higher priority, a lot of users are having issues with HLE in a lot of games and LLE is too slow (I have an i5 and it is really slow compared to HLE)

Actions

Copy link

#64

Updated by Xtreme2damax over 13 years ago

"Only those with i7s see little to no performance loss with LLE."

That's exactly why any HLE issues are low priority. Accuracy is what is being focused on, performance is only an afterthought. Be thankful developers care about performance at all, they could have gone the Mame route where even crappy looking games are unplayable on modern hardware or Bsnes that requires a 2+ Ghz processor to emulate Snes games due to cycle accuracy. Also if HLE issues were easy to fix they probably would have been fixed by now, some issues such as syncing issues may never be fixed due to limitations of HLE emulation.

Everyone is going to just have to deal with speed issues and use LLE if they want decent audio or splurge on new hardware. Emulation is not meant to be cheap and wasn't actually meant to play games, emulation is a niche hobby and a learning experience. If developers stuck to cycle accurate emulation, everyone would complain about how slow their games are. Emulation has been tarnished by those too cheap too buy the hardware and games and pirate everything.

A last generation i7 can emulate LLE quite well, although a SB cpu would be 100% in most cases, unfortunately that is the price you have to pay. I mean you don't see developers breaking everything so they can get the emulator running decently on a Pentium 4 and Geforce 5xxx/6xxx if that was even possible?

Actions

Copy link

#65

Updated by hrydgard over 13 years ago

Just to clarify one thing, it is absolutely possible to obtain the same accuracy with HLE as with LLE, and with much greater performance. The obstacle is a quite large amount of hard reverse engineering work and lots of programming, that someone will have to do to reach this goal.

Actions

Copy link

#66

Updated by Xtreme2damax over 13 years ago

That's not what was said in the past though, at least in regard to syncing issues which at the time it was stated those would be impossible to fix with HLE.

Actions

Copy link

#67

Updated by gabrielmorano over 13 years ago

Actually i tested it on an i7 with lle and it was still slow :s
I get the point of looking stability so that is why i said that HLE is not the priority, but not something to throw off
that or either make LLE work better (ergo most ppl arge about the games been slow because of this)

and of course emulation is not cheap as you have to use something at that is twise as powerfull than the original.
It's still a loooooooong step and so far it has improved a lot

Actions

Copy link

#68

Updated by marcel.werner3 over 13 years ago

Yeah, I do understand the main goal is accuracy but the majority of Dolphin users are just not able to use LLE (in a playable manner), so it would be nice if someday some dev would come along who would be willing to give HLE another chance ^^

Actions

Copy link

#69

Updated by hrydgard over 13 years ago

xtreme: Not impossible, just requires more work. It is possible to limit HLE to generate the same number of samples per audio frame as LLE, mostly getting rid of the sync issues but instead introducing the same sound skipping issues that LLE has and will always have (but should be okay on slower CPUs than are required for LLE since less CPU power is used).

Of course, games could use crazy opcodes that really depended on exact cycle counting, and they might already be. In that case it will be practically impossible to obtain the same accuracy indeed, but I doubt that the audio synchronization of any game depends on this in practice, the main sync issue is that HLE will generate as many samples are needed to keep the audio stream going without skips, while LLE will of course generate the correct number of samples, causing skipping if the game runs too slow.

marcel, gabriel: Saying that it would be nice doesn't accomplish the work needed :)

Actions

Copy link

#70

Updated by hrydgard over 13 years ago

s/opcodes/ucodes

Actions

Copy link

#71

Updated by Xtreme2damax over 13 years ago

Keep poking at Jack.Frost, he was working on RE'ing the AFC code (SMG, SMG2, ZTP, MK:DD) early last year but stopped for some reason. I think his code is still up on Pastebin or Pastie for anyone that wants to start from where he left off if he won't work on it anymore.

http://pastie.org/pastes/1107951

Actions

Copy link

#72

Updated by gabrielmorano over 13 years ago

+1 to hrydg for saying it's not impossible...

like i said, i didn't meant that this is an inmediat issue as there are far more important issues (like the fifo's) but i do think that at some point someone could take this in hand ;) (i do agree that stability and compatibility are more important)

as i see HLE it's another learning challenge if i "quote" xtreme ;)

Actions

Copy link

#73