Emulator Issues #4488

Post-processing shaders list needs to exclude some files

Added by MofoMan2000 over 9 years ago.

% Done:


Operating system:
Issue type:
Relates to usability:
Relates to performance:
Relates to maintainability:
Regression start:
Fixed in:


What's the problem?
In the post-processing shaders list (for OpenGL backend) a couple things that obviously aren't shaders show up in the list. For example, the README file and a .svn folder (if you check out the shaders repository separately). These are obviously never going to be actual shaders and can probably be explicitly excluded from the shaders list.


Dolphin version with the problem (as it appears in the title bar, Ex.: "R
4779" or "R 6403M"):
Probably every revision since post-processing shaders were implemented.

(optional) Dolphin version that does not have the problem:

Operating system and version: Any
32-bit or 64-bit: Any

Game ID (as it appears in game properties, Ex.: "GZ2P01" or "RSBE01"): Any

Was the ISO a plain dump from disc, compressed and/or scrubbed?
DoEsN'T MaTtEr

Please provide any additional information below.
This seems like an easy enough thing to fix.


#1 Updated by over 9 years ago

Exclude folder should be easy but not text file.
It is hard to separate non-shader text file without checking its content.

#2 Updated by MofoMan2000 over 9 years ago

Yeah I'm not suggesting it prereads every txt file, I just think the one called README can be explicitly excluded, unless at some point we expect to have a shader named README. Which would be pretty stupid and very unlikely really.

#3 Updated by lpfaint99 over 9 years ago

here's a quickly thrown together patch

#4 Updated by NeoBrainX over 9 years ago

I'd rather only check if the filename is "README" and additionally insert a line like if (entry.children[i].isDirectory) continue;
Hardhacking the fact that we're using subversion is kinda stupid imo :D

#5 Updated by lpfaint99 over 9 years ago

looking into the code more the shaders actually append .txt when applied so anything that doesnt fit into the strcmp with .txt should be ignored

#6 Updated by lpfaint99 over 9 years ago

a better patch

#7 Updated by NeoBrainX over 9 years ago

Uhm, why not just only add the file to the shader list if a) it's file extension is .txt b) it's filename is not "README.txt"?

#8 Updated by lpfaint99 over 9 years ago

I assume that you are talking about the removal of the extension before the compare with readme?
Since the list currently shows just the name without the extension I left that removal in. I don't really care either way, so I'll defer to your expertise :)

#9 Updated by Billiard26 over 9 years ago

We could use a different file extension for the shaders.

#10 Updated by Sonicadvance1 over 9 years ago

.cg is always a popular extension for Nvidia CG shaders

#11 Updated by Sonicadvance1 over 7 years ago

  • Status changed from New to Fixed

This is fixed in the GLSL merge.

Also available in: Atom PDF