Project

General

Profile

Emulator Issues #4504

DJ Turntable extension is broken. Here is the fix

Added by spycorfu about 9 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
Category:
Controls
% Done:

0%

Operating system:
N/A
Issue type:
Other
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

*What's the problem?

DJ Turntable extension is broken. The crossfader is stuck to the left and not in the default state which makes the extension useless

*Dolphin version with the problem (as it appears in the title bar, Ex.: "R
4779" or "R 6403M"):

All versions

*Game ID (as it appears in game properties, Ex.: "GZ2P01" or "RSBE01"):

SWAP52

*Please provide any additional information below.

svn/ trunk/ Source/ Core/ Core/ Src/ HW/ WiimoteEmu/ Attachment/ Turntable.cpp

The turntable.ccp is the problem. I fixed it using CC+ and I changed 4 lines. The turntable.ccp hasn't been updated since r6849.
I would like to see it implemented in future versions of the program.

spy28


Related issues

Has duplicate Emulator - Emulator Issues #4510: Turntable extension scratch down problemDuplicate

History

#2 Updated by NeoBrainX about 9 years ago

Post a patch instead, or tell us what you actually changed...

#3 Updated by DimitriPilot3 about 9 years ago

  • Issue type set to Other
  • Category set to controls

Starting from line 98, the following:

// crossfade slider
{
u8 cfs = 0;
m_crossfade->GetState(&cfs, 8, 7);

ttdata->slider = cfs;
}

was changed into:

// crossfade slider
    {
    s8 cfs = 0;
    m_crossfade->GetState(&cfs, focus ? 0xF : 0);
    cfs+=15;
    cfs/=2;
    ttdata->slider = cfs;
    }

(the attached patch was made using TortoiseSVN 1.6.14 on Windows)

#4 Updated by NeoBrainX about 9 years ago

sigh don't upload such large attachements without a good reason,
read this first before using our issue tracker: http://code.google.com/p/dolphin-emu/wiki/GoogleCodeRules

#5 Updated by NeoBrainX about 9 years ago

Fwiw, does the fix have any logic behind it or is it just trial&error?

Also, wouldn't it be better to do cfs = (cfs + 15) / 2 instead, since we might run into problems if cfs is e.g. 255 otherwise?

#6 Updated by death2droid about 9 years ago

From what i read NeoBrainX the guy that created it just did it by trial and error.

#7 Updated by knglrk about 9 years ago

wow its about time, i was one person that reported this problem and several others in a while back in the forums.anyways great work who ever fix the turntable extension.

#8 Updated by Billiard26 about 9 years ago

  • Status changed from New to Accepted

I would think swapping the 7 and 8 in the original code would fix the issue,
but I recall someone claiming that did not work.

#9 Updated by Billiard26 about 9 years ago

issue 4510 has been merged into this issue.

#10 Updated by Billiard26 over 7 years ago

Will someone tell me if "swapping the 7 and 8 in the original code" fixes the issue?

#11 Updated by spycorfu over 7 years ago

if i remember correctly, it doesnt fix the issue

#12 Updated by Billiard26 over 7 years ago

  • Status changed from Accepted to Fixed

This issue was closed by revision 5ff77f9c882a.

#13 Updated by delroth over 7 years ago

This issue was closed by revision 5ff77f9c882a.

Also available in: Atom PDF