https://bugs.dolphin-emu.org/https://bugs.dolphin-emu.org/favicon.ico?12011-05-16T08:26:54ZDolphin bug trackerEmulator - Emulator Issues #4504: DJ Turntable extension is broken. Here is the fixhttps://bugs.dolphin-emu.org/issues/4504?journal_id=6923842011-05-16T08:26:54ZNeoBrainXNeoBrainX@gmail.com
<ul></ul><p>Post a patch instead, or tell us what you actually changed...</p>
Emulator - Emulator Issues #4504: DJ Turntable extension is broken. Here is the fixhttps://bugs.dolphin-emu.org/issues/4504?journal_id=6923852011-05-16T08:50:10ZDimitriPilot3DimitriPilot3@gmail.com
<ul><li><strong>Issue type</strong> set to <i>Other</i></li><li><strong>Category</strong> set to <i>controls</i></li></ul><p>Starting from line 98, the following:</p>
<pre><code>// crossfade slider
{
u8 cfs = 0;
m_crossfade->GetState(&cfs, 8, 7);
ttdata->slider = cfs;
}
</code></pre>
<p>was changed into:</p>
<pre><code>// crossfade slider
{
s8 cfs = 0;
m_crossfade->GetState(&cfs, focus ? 0xF : 0);
cfs+=15;
cfs/=2;
ttdata->slider = cfs;
}
</code></pre>
<p>(the attached patch was made using TortoiseSVN 1.6.14 on Windows)</p>
Emulator - Emulator Issues #4504: DJ Turntable extension is broken. Here is the fixhttps://bugs.dolphin-emu.org/issues/4504?journal_id=6923862011-05-16T14:11:46ZNeoBrainXNeoBrainX@gmail.com
<ul></ul><p><em>sigh</em> don't upload such large attachements without a good reason,<br>
read this first before using our issue tracker: <a href="http://code.google.com/p/dolphin-emu/wiki/GoogleCodeRules" class="external">http://code.google.com/p/dolphin-emu/wiki/GoogleCodeRules</a></p>
Emulator - Emulator Issues #4504: DJ Turntable extension is broken. Here is the fixhttps://bugs.dolphin-emu.org/issues/4504?journal_id=6923872011-05-16T14:15:50ZNeoBrainXNeoBrainX@gmail.com
<ul></ul><p>Fwiw, does the fix have any logic behind it or is it just trial&error?</p>
<p>Also, wouldn't it be better to do cfs = (cfs + 15) / 2 instead, since we might run into problems if cfs is e.g. 255 otherwise?</p>
Emulator - Emulator Issues #4504: DJ Turntable extension is broken. Here is the fixhttps://bugs.dolphin-emu.org/issues/4504?journal_id=6923882011-05-17T06:34:56Zdeath2droiddeath2droid@gmail.com
<ul></ul><p>From what i read NeoBrainX the guy that created it just did it by trial and error.</p>
Emulator - Emulator Issues #4504: DJ Turntable extension is broken. Here is the fixhttps://bugs.dolphin-emu.org/issues/4504?journal_id=6923892011-05-24T04:20:40Zknglrkknglrk@gmail.com
<ul></ul><p>wow its about time, i was one person that reported this problem and several others in a while back in the forums.anyways great work who ever fix the turntable extension.</p>
Emulator - Emulator Issues #4504: DJ Turntable extension is broken. Here is the fixhttps://bugs.dolphin-emu.org/issues/4504?journal_id=6923902011-05-28T07:46:29ZBilliard26jordan.woyak@gmail.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Accepted</i></li></ul><p>I would think swapping the 7 and 8 in the original code would fix the issue,<br>
but I recall someone claiming that did not work.</p>
Emulator - Emulator Issues #4504: DJ Turntable extension is broken. Here is the fixhttps://bugs.dolphin-emu.org/issues/4504?journal_id=6923912011-06-12T23:24:15ZBilliard26jordan.woyak@gmail.com
<ul></ul><p>Issue 4510 has been merged into this issue.</p>
Emulator - Emulator Issues #4504: DJ Turntable extension is broken. Here is the fixhttps://bugs.dolphin-emu.org/issues/4504?journal_id=6923922013-01-09T06:52:06ZBilliard26jordan.woyak@gmail.com
<ul></ul><p>Will someone tell me if "swapping the 7 and 8 in the original code" fixes the issue?</p>
Emulator - Emulator Issues #4504: DJ Turntable extension is broken. Here is the fixhttps://bugs.dolphin-emu.org/issues/4504?journal_id=6923932013-01-18T08:49:16Zspycorfuspycorfu@gmail.com
<ul></ul><p>if i remember correctly, it doesnt fix the issue</p>
Emulator - Emulator Issues #4504: DJ Turntable extension is broken. Here is the fixhttps://bugs.dolphin-emu.org/issues/4504?journal_id=6923942013-01-18T19:43:31ZBilliard26jordan.woyak@gmail.com
<ul><li><strong>Status</strong> changed from <i>Accepted</i> to <i>Fixed</i></li></ul><p>This issue was closed by revision 5ff77f9c882a.</p>
Emulator - Emulator Issues #4504: DJ Turntable extension is broken. Here is the fixhttps://bugs.dolphin-emu.org/issues/4504?journal_id=6923952013-01-20T06:30:45Zdelrothdelroth@gmail.com
<ul></ul><p>This issue was closed by revision 5ff77f9c882a.</p>