Project

General

Profile

Actions

Emulator Issues #4561

closed

CT6 CST1 "Insert ASM" C2xxxxxx Gecko Code handling is incomplete

Added by Klinechr123 almost 13 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What's the problem?
When several codes that allow Brawl- to function properly, the game and emulator crash. The following crash the game:

Tech Window v.05
Shield Stun V8
Dash Dancing
Universal Walljumping

Included in the extra information will be each code's hex.

Dolphin version with the problem (as it appears in the title bar, Ex.: "R
4779" or "R 6403M"):
The version used is r7528.

(optional) Dolphin version that does not have the problem:

Operating system and version: Windows 7 Ultimate
32-bit or 64-bit: 64-bit

Game ID (as it appears in game properties, Ex.: "GZ2P01" or "RSBE01"): RSBE01

Build command-line (not on Windows):

Was the ISO a plain dump from disc, compressed and/or scrubbed?
The ISO was originally a plain dump from the disc, modified so that it has all of the files Brawl- uses (over 300). The ISO itself is not a problem, as it does not crash unless codes are used with it.

Please provide any additional information below.
The codes and their hex, in order of mention above (any extra text after the code is OMITTED in the actual code used, codes are entered in proper Dolphin format):

Tech Window v.05 [spunit262]

  • C277F190 00000012
  • 80810010 2C040046
  • 41A00080 2C04004C
  • 41A10078 80BF0068
  • 88C5008F 2C06000F
  • 41A10068 88E5008E
  • 7CC63A14 2C060032
  • 41800058 2C040049
  • 41820050 41A00008
  • 3884FFFC 3884FFBA
  • 5484083C 38840060
  • 2C040062 41810030
  • 41820010 80C50038
  • 54C66D3E 48000014
  • 80E50074 50E4EFFE
  • 80C5003C 7CC69E70
  • 2C0607E5 41A00008
  • 60840001 90810010
  • 60000000 00000000
  • C2765394 00000005
  • 88C30058 2C060032
  • 41A10014 7C060214
  • 2C0000FF 41800008
  • 380000FE 98030058
  • 60000000 00000000
    Teching window (15) [2C06000F]5th Line
    Missed teching window (teching window included) (35) [2C060032]7th,21st Lines

Shield Stun V8 [spunit262]

  • C28753FC 00000005
  • 83810034 8083013C
  • 2C040000 41810014
  • 1F9C0016 3B9C002B
  • 3880000A 7F9C23D6
  • 60000000 00000000
    (Old shield stun*X+Z)/Y=new shield stun
    Prelim value: 6.5 (old value = 10)
    1F9CXXXX=0016
    3B9CZZZZ=002B
    3880YYYY=000A

Dash Dancing [Phantom wings]

  • C271F474 00000004
  • 81830058 2C0C000E
  • 4182000C C0230040
  • 48000008 FC20D090
  • 60000000 00000000

Universal Walljumping [Dantarion]

  • C285893C 00000003
  • 2C030024 4082000C
  • 38600001 48000008
  • 7C63002E 00000000

Related issues 3 (0 open3 closed)

Has duplicate Emulator - Emulator Issues #4020: Brawl Minus - Can't play past title screenDuplicate

Actions
Has duplicate Emulator - Emulator Issues #4197: pokemon battle revolution - none of the gecko codes workDuplicate

Actions
Has duplicate Emulator - Emulator Issues #4596: C2 Gecko Code TypesDuplicate

Actions
Actions #1

Updated by Klinechr123 almost 13 years ago

When USING*
Wow, that one is a real slip-up. Sorry, guys.

Actions #2

Updated by Billiard26 almost 13 years ago

Those are all "insert asm" type codes.

Actions #3

Updated by Klinechr123 almost 13 years ago

I'm not exactly sure what that means. Can you elaborate? I'm a bit new at this.

Actions #4

Updated by MofoMan2000 almost 13 years ago

Using cheat codes which modify memory (Gameshark, Action Replay, Gecko, etc.) Can cause instability in any game at any time. If these codes are correct and don't cause instability on real hardware then it's either an issue with emulation accuracy or it depends on the software running at 100% speed for some reason.

If there is an error in the codes, please post an issue in the dolphin-cheats-database SVN instead where it can be dealt with quickly. Generally speaking, though, instability can and should be expected when using cheat codes like these.

Actions #5

Updated by Klinechr123 almost 13 years ago

Thanks for the timely response and great explanation. I'll be sure to take my issue there posthaste.

Actions #6

Updated by nodchip almost 13 years ago

Sorry for late response. I think this issue is due to my "insert asm" type (CST1) handler. I implemented the CST1 handler in Source/Core/Core/Src/PowerPC/PPCAnalyst.cpp by interrupting the PowerPC code analysis routine. My code works as inserting PowerPC code into where the code specify. This behavior is different from what the real Gecko does. In ordinal cases, my handler works well. But if the CST1 code creates subroutines, it does not works because my handler can't handle such code. If CST1 code create subroutines in itself, my code does not work and the emulator will crash. Currently I don't have any ideas to fix this issue. Unfortunately I don't have time to commit for Dolphin project now. I'm sorry.

Actions #7

Updated by Billiard26 almost 13 years ago

Issue 4596 has been merged into this issue.

Actions #8

Updated by Billiard26 almost 13 years ago

Issue 4020 has been merged into this issue.

Actions #9

Updated by Billiard26 almost 13 years ago

  • Status changed from New to Accepted
  • Priority set to Low
  • Issue type set to Bug
Actions #10

Updated by Billiard26 almost 13 years ago

Issue 4197 has been merged into this issue.

Actions #11

Updated by skidau over 12 years ago

  • Status changed from Accepted to Fixed

This issue was closed by revision 80504efcdf6d.

Actions #12

Updated by skidau over 12 years ago

This issue was closed by revision 69b2d4ddc1cb.

Actions

Also available in: Atom PDF