Project

General

Profile

Actions

Emulator Issues #4906

closed

Xenoblade Chronicles black sky on Win32

Added by hatarumoroboshi about 13 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
Windows
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

  1. Game Name and ID (as it appears in right click > properties: "GZ2P01",
    "RSBE01", etc):
    Xenoblade Chronicles - SX4P01

2) What is the expected output? What do you see instead?
At the first menu screen (the one with the sword in the ground) and also in the game, the sky is completely black (instead of light blue) behind the clouds.

3) Did the game ever work correctly (i.e. not have this problem) on an
earlier version of dolphin? Please specify the exact revision when the
problem began.
Worked on r3.0-67 (a5a2562e5900) but doesn't work anymore with adef86c1ef29 (I tried with the new shader cache version beta r3.0-94 and it doesn't work, so it may be this that caused the problem)

4) What steps will reproduce the problem?

  1. Launch the game
  2. Wait
  3. The intro menu has a black sky in the background (also in-game there's black sky as well)

5) What version of dolphin are you using (32bit/64bit along with the
version as it appears in the title bar: "R 4779", "R 6403M", "3.0", etc)?
On what operating system, drivers, and hardware? Be sure to list OS,
graphics driver information, and video card model if you are having
graphics problems, for example.
r3.0-147 (b4d751e43cbf) on Windows XP SP3, Hd4850, E8400

6) Please provide any additional information below.
As I said it may be due to the new shader cache version.
The problem appears in both DX9 and OpenGL

7) Attachments. IMPORTANT! We have a limited storage quota on
GoogleCode, so please use a 3rd party host for screenshots or any other
files (http://min.us/ for example).
Tell me if you need some comparison photos to be attached.


Related issues 1 (0 open1 closed)

Has duplicate Emulator - Emulator Issues #4926: Xenoblade Chronicles DSI exception during intro cut-sceneDuplicate

Actions
Actions #1

Updated by hatarumoroboshi about 13 years ago

From my testing seems that with the new shader cache version Xenoblade needs the projection hack (-)+zNear to be activated (ticked without zNear correction).
In this way the day-sky is no more black and returns light blue.

Actions #3

Updated by Anonymous about 13 years ago

fwiw, the sky seems fine for me in the latest master - r5b2c5c9ce37b Any chance you could try that? Also try manually deleting your shadercache files...

Actions #5

Updated by hatarumoroboshi about 13 years ago

With r5b2c5c9ce37b Still black sky if I don't enable the projection hack.
Here WINDOWS XP SP3 32-bit, Ati Hd4850 Catalyst 11.5, Intel E8400, Dolphin 32-bit.

Actions #6

Updated by Anonymous about 13 years ago

Eh, whatever... :p

Actions #7

Updated by hatarumoroboshi about 13 years ago

Sorry to have blamed the new shader cache version because it's not guilty...the black sky comes with r3.0-79 (revision 8b8e60c2767d - in fact it comes with r3.0.77 http://www.emucr.com/2011/09/dolphin-git-30-77.html but I can't find the reference on the changes on master...where are them? Numbers got mad?); instead the sky is perfect with r3.0-71 (Revision c0dd84cf7d04).
Furthermore there's a DSI Exeption problem that affects these revision but I'll open another issue for that...

Actions #8

Updated by hatarumoroboshi about 13 years ago

Ok, now I found out (these absurd revision numbers are driving me crazy), there were two revisions with the same description, so it is definitely as follows: light-blue sky on Revision c0dd84cf7d04 (3.0-71) and black sky on Revision 11933bf6b5fd (3.0-77).

Actions #9

Updated by Anonymous about 13 years ago

btw things like git bisect make regression testing very easy: http://book.git-scm.com/5_finding_issues_-_git_bisect.html

still, this is either an amd or user issue...

Actions #10

Updated by hatarumoroboshi about 13 years ago

Must be an XP issue because in issue 4926 hbk sais he has black sky using a nVidia Geforce GTX460.

Actions #11

Updated by Anonymous about 13 years ago

..or 32bit issue ;)

Actions #12

Updated by hatarumoroboshi about 13 years ago

These are the changes from r3.0-71 to r3.0-77 that may have caused the issue:

Dolphin Git changelog:

  • disable ltcg for release build
  • vs2010: Disable LTCG for realz
  • Fix various cases in scissor rect emulation.
    Patch by delroth.
  • apply to dx9 and dx11 backends as well
  • Merge some scissor rect related code to VideoCommon.
  • Merge branch 'scissoring-fixed'
    Fixes various cases in scissor rect emulation. This should fix glitches in various games, right now it's only known to (partially) fix Baten Kaitos: Eternal Wings.
    Fix by delroth, port to D3D9/11 by godisgovernment, cleanup by me.
Actions #13

Updated by skidau about 13 years ago

Issue 4926 has been merged into this issue.

Actions #14

Updated by hatarumoroboshi about 13 years ago

Is it possible to rename the issue "Xenoblade Chronicles black sky and DSI exception during intro cut-scene"? Thanks.

Actions #15

Updated by NeoBrainX about 13 years ago

  • Status changed from New to New
  • Category set to gfx

The DSI exception is unrelated to this issue, so I'll leave the issue summary this way.

Possibly caused by the merge of the scissoring-fixed branch, CC'ing delroth.

Actions #16

Updated by gabrielmorano about 13 years ago

This issue never happened to me, and the last rev i checked was in v3.0-183.

sky and every single gfx in the game works fine and normal.
tough the game tends to crash time to time, but still... don't recon this gfx problem
not in d3d or openGL

Actions #17

Updated by gabrielmorano about 13 years ago

maybe some incompatibility with the Graphic Card or an XP thing (I use 7 x64)

Actions #18

Updated by gabrielmorano about 13 years ago

Tested it with my GTS 450
and my old pc wich has a GeForce 8400 gs 512
neither of them had the black sky thing, so yeap... user compatibility thing or XP problem

Actions #19

Updated by Anonymous about 13 years ago

Could someone experiencing the issue please test r95517a9741175f15124dc11e132620a23bec7a19 and rb867c21fea6401c0f9886129621bb0dbae962a4a specifically? Thanks!

Actions #20

Updated by hatarumoroboshi about 13 years ago

Please can someone post a build link on those revs? Thank you

Actions #21

Updated by tommyhl2.SS about 13 years ago

No issues here, HD6650, Windows 7, 64-bit. Try using an OS that is not 10 years old and try again.

Actions #22

Updated by delroth about 13 years ago

Can't reproduce either. HD6770, Linux x86_64, Catalyst 11.8.

Actions #23

Updated by Faramir1999 about 13 years ago

have the same problem on ATI4870, WinXP SP3

Actions #24

Updated by carlos.ismael.braz about 13 years ago

Could this be related to the texture issue in Tales of Graces? http://code.google.com/p/dolphin-emu/issues/detail?id=2999

Actions #25

Updated by hatarumoroboshi about 13 years ago

No, this problem showed up only with r3.0-77

Actions #26

Updated by hbk013 about 13 years ago

To be precise - r3.0-77 and later but, as the devs said, it can be fixed by using the Custom Projection Hack -> (-)+ zNear in the game properties.
I tested the game on a friends PC with the following specs:
CPU: Intel Q6600
RAM: 4GB
GPU: ATI Radeon 3850
OS: Windows 7 Ultimate 32-bit
and got the DSI exception.

Actions #27

Updated by hbk013 about 13 years ago

And the dark sky is also showing while running Xenoblade Chronicles on Win 7 32-bit.

Actions #28

Updated by hatarumoroboshi about 13 years ago

Ok, so now we know for sure that the black sky and the DSI exception are a 32-bit issue.

Actions #29

Updated by hbk013 about 13 years ago

That's what it looks like. My advice is - everyone who has this issue to use the Dolophin 3.0 version(no the git-s) untill the devs resolve the issue. And, I know it's offtopic, the OpenGL plugin in Kirby's Return to Dreamland is broken.

Actions #30

Updated by tommyhl2.SS about 13 years ago

Can those with the black sky issue please test with the official 3.0 release?

Actions #31

Updated by hatarumoroboshi about 13 years ago

As I wrote the issues (Black sky and DSI exception) start with r3.0-77; the official 3.0 isn't affected like every release until 3.0-71 included.

Actions #32

Updated by hbk013 about 13 years ago

If we want to be more precise the unaffected versions are: the official 3.0 and every other until r.3.0.-76(new-shadercache-uids). r.3.0-76 is the last revision before the start of the black sky and dsi exception issues.

Actions #33

Updated by NeoBrainX about 13 years ago

rbcb8d11c1b9f surely did NOT cause this issue. Clean your ShaderCache directory between different builds when testing that revision range.

Geez, what's wrong with people not doing reliable testing these days >_>

Also, those "3.0-76" numbers are useless, tell us the git hash in the future instead (from the about dialog).

Actions #34

Updated by hatarumoroboshi about 13 years ago

I quote myself with the information that I've already written and that indicate exactly the information needed (the revision responsible is between r3.0-71 and r3.0-77 but unfortunately I couldn't find any build between them):

Ok, now I found out (these absurd revision numbers are driving me crazy), there were two revisions with the same description, so it is definitely as follows: light-blue sky on Revision c0dd84cf7d04 (3.0-71) and black sky on Revision 11933bf6b5fd (3.0-77).

These are the changes from r3.0-71 to r3.0-77 that may have caused the issue:

Dolphin Git changelog:

  • disable ltcg for release build
  • vs2010: Disable LTCG for realz
  • Fix various cases in scissor rect emulation.
    Patch by delroth.
  • apply to dx9 and dx11 backends as well
  • Merge some scissor rect related code to VideoCommon.
  • Merge branch 'scissoring-fixed'
    Fixes various cases in scissor rect emulation. This should fix glitches in various games, right now it's only known to (partially) fix Baten Kaitos: Eternal Wings.
    Fix by delroth, port to D3D9/11 by godisgovernment, cleanup by me.
Actions #35

Updated by NeoBrainX about 13 years ago

Fwiw, does this happen with native IR, efb to ram, real XFB as well?

Actions #36

Updated by hatarumoroboshi about 13 years ago

Yes, it happens with every possible video configuration...the only way to have back blue sky is to enable the projection hack (-)+zNear (ticked without zNear correction), but even with the projection hack the DSI exception is still happening.

Actions #37

Updated by Anonymous about 13 years ago

OK...here are the builds which I wanted you to test before...

r95517a9741175f15124dc11e132620a23bec7a19 and b867c21fea6401c0f9886129621bb0dbae962a4a:
http://min.us/mbozDqCOc8#1

Actions #38

Updated by hbk013 about 13 years ago

I tested r95517a9741175f15124dc11e132620a23bec7a19 and b867c21fea6401c0f9886129621bb0dbae962a4a and the game froze when you entered combat, more specifically when you use a skill after you have entered a battle. The projection hack((-)+zNear) was enabled.

Actions #39

Updated by hbk013 about 13 years ago

This was the last revision where evyrithing worked perferct:
Revision: 34671140e09f308975a3c05bb3d48c157ea45c8f.
Branch: master

Actions #40

Updated by delroth about 13 years ago

This commit (34671140e09f308975a3c05bb3d48c157ea45c8f) does not even exist...

Actions #41

Updated by hbk013 about 13 years ago

I downloaded the file from http://forums.dolphin-emulator.com/showthread.php?tid=14356&pid=169677 and it's name was 3.0-71 Xenoblade HLE Hack v3.1 Win32.7z.

Actions #42

Updated by Anonymous about 13 years ago

this topic is ONLY about the black sky issue, obviously...so do proper testing kthx.

Actions #43

Updated by hbk013 about 13 years ago

OK, sorry. So to sum things up: the black sky appears in these two build and every build after them(that's what 32-bit OS users experienced).
As for the game freezing and the DSI exception also happening on 32-bit systems I think this was Issue 4926 and after it disappeared I thought it was merged with Issue 4906.

Actions #44

Updated by hatarumoroboshi about 13 years ago

Thanks, I just tested r95517a9741175f15124dc11e132620a23bec7a19 (r3.0-73) and it's definitely this revision that causes black sky and DSI exception.

Actions #45

Updated by delroth almost 13 years ago

  • Status changed from New to Work started
  • Category deleted (gfx)
  • Operating system Windows added

This may be because of /fp:fast. Compiling with /fp:precise fixes the black sky issue, currently doing more testing to see if the DSI exceptions are fixed too.

Actions #46

Updated by hatarumoroboshi almost 13 years ago

I'll keep the finger crossed, thank you.

Actions #47

Updated by delroth almost 13 years ago

Using r3.0-73 I was not able to get the DSI exception by playing Xenoblade's intro cutscene and doing 3-4 fights. Is there a reliable way to cause it or is it a random bug?

Actions #48

Updated by hatarumoroboshi almost 13 years ago

No, it's not random, it always compares at the same point of the intro, where Dunban comes out for the first time and faces against the Mechon. (on Ati HD4850, E8400 and WinXP 32-bit SP3).
With r3.0-73 r95517a9741175f15124dc11e132620a23bec7a19 you get the black sky or not?

Actions #49

Updated by Anonymous almost 13 years ago

@delroth: we already should be using fp:precise in the effected ppc files via #pragma.
This means it's in some other region of code. Would be cool to figure out which instead of unsetting fp:fast everywhere.

Actions #50

Updated by delroth almost 13 years ago

  • Status changed from Work started to Fixed

This issue was closed by revision 70b6c4280f72.

Actions

Also available in: Atom PDF