Project

General

Profile

Actions

Emulator Issues #495

closed

[OGL] Too few GL_REPORT_ERROR to be useful

Added by tinctorius almost 16 years ago.

Status:
Won't fix
Priority:
Low
Assignee:
-
Category:
GFX
% Done:

0%

Operating system:
N/A
Issue type:
Task
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Though there are quite a few GL_REPORT_ERROR() and -D() 'calls' in Dolphin,
there are way too few for it to be useful. Many OpenGL calls aren't
followed by a call to GL_REPORT_ERROR, which causes the one at for instance
TextureMngr.cpp (line 477) to attract almost all of the actual errors. Note
the comment there about Super Mario Sunshine; the same is true for various
parts of Metroid Prime (especially with water-like structures, such as the
poisoned water before Flaahgra or the lava in the Magmoor Caverns).

I noticed this became a problem when I tried to fix issue 493, where I
changed the behaviour of SetScissorRect() and added a GL_REPORT_ERROR just
to be sure. The errors that were attracted by TextureMngr.cpp before were
now often completely taken over by Render.cpp, while the call to glScissor
always had the right values.

This may be just a janitoral job, but could someone add GL_REPORT_ERROR()
after all OpenGL calls? Without it, I think debugging the OpenGL plugin is
impossible.

Actions #1

Updated by XTra.KrazzY over 15 years ago

  • Status changed from New to Accepted
  • Issue type set to Task
  • Priority set to Low
  • Category set to gfx
  • Operating system N/A added

Sounds like a feasible janitorial task, though it would make the OGL code look ugly.

Actions #2

Updated by death2droid about 15 years ago

Do you actually want this done still?

Actions #3

Updated by XTra.KrazzY about 15 years ago

  • Status changed from Accepted to Won't fix
Actions

Also available in: Atom PDF