Project

General

Profile

Actions

Emulator Issues #5060

closed

GLSL branch Bull Request/Code Review

Added by Sonicadvance1 over 12 years ago.

Status:
Won't fix
Priority:
Normal
Assignee:
-
Category:
GFX
% Done:

0%

Operating system:
N/A
Issue type:
Feature request
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Name of clone:
GLSL-Master

Purpose of code changes on this branch:
Allow the use of GLSL instead of Nvidia CG in the OpenGL plugin to allow support for OSes that don't support it(FreeBSD) and also to take a step forward in getting Dolphin on more portable devices

When reviewing my code changes, please focus on:
Basically everything. Need more information, poke me of course.

After the review, please pull into branch:
Master

Actions #1

Updated by Autoran1 over 12 years ago

Auto merging conflict with master with these files
/Plugin_VideoOGL/Src/Render.cpp
/Plugin_VideoOGL/Src/PixelShaderCache.cpp

Actions #2

Updated by Sonicadvance1 over 12 years ago

PixelShaderCache.cpp merge conflict is because git is being stupid and can't notice that I moved the contents of a function. Render.cpp is also a bit silly but easily fixed.

Actions #3

Updated by Sonicadvance1 over 12 years ago

Not working Currently!!!
Virtual XFB!
Just making a note here.

Actions #4

Updated by Sonicadvance1 over 12 years ago

Another Not currently working!!
Cubivore CRASHES!
Yea, real strange yea?

Actions #5

Updated by Sonicadvance1 over 12 years ago

Well would you look at that, I fixed cubivore.

Actions #6

Updated by Sonicadvance1 over 12 years ago

Note here.
Apparently EFB to RAM doesn't work in Metroid 3 or creates a weird effect?
I don't have this game, seeing if I can find a game that makes a weird effect with it.

Actions #7

Updated by Sonicadvance1 over 12 years ago

Also tested XFB, both virtual and real, and it seems to work fine here. Any other issues yet that doesn't allow this to be merged?

Actions #8

Updated by parlane about 12 years ago

Why is this still waiting? Should either be accepted or rejected by now?

Actions #9

Updated by Anonymous about 12 years ago

It needs to be fixed on the real glsl 330 version, instead of the compatibility profile. That should fix ATI hardware as well.

Actions #10

Updated by NeoBrainX about 12 years ago

Ya, atm EFB copies are completely broken on ATI hardware unless UBOs are disabled. Also there's some vertex position glitches when UBOs are disabled.

Actions #11

Updated by Anonymous about 12 years ago

I wish nv had a "simulate crappy driver" function :P

Actions #12

Updated by Sonicadvance1 over 11 years ago

  • Status changed from New to Won't fix

The changes recently for getting support for the openGL 3.3 core profile will change this quite a bit. Closing for now.

Actions

Also available in: Atom PDF