Emulator Issues #5068
closed
Request review and test of cmake-osx2 branch
0%
Description
Name of clone:
Main dolphin repository, branch cmake-osx2
Purpose of code changes on this branch:
To support building on Mac OS X with CMake. It will allow us to retire SCons, to reduce the amount of duplicate work in maintaining the build. Also it might allow generating Xcode projects in the future (not a goal yet for this branch).
When reviewing my code changes, please focus on:
- whether the resulting bundle has any problems that do not exist with the SCons build
- whether the changes I made in the CMakeLists.txt files don't break other platforms using CMake
- whether there are better ways to approach things with CMake (I'm new to CMake)
After the review, please pull into branch:
master
Updated by mthuurne over 12 years ago
Some progress tracking notes:
"make install" did not work. This has been fixed in 4c7c29b8b6bf.
Translations are not copied into bundle yet.
OpenCL is linked to, but is not available on OS X 10.5. Is there support in Dolphin to use OpenCL conditionally? Is OpenCL used at all by Dolphin on OS X?
There is a linker warning about the QuickTime framework not having x86_64 code. Can be suppressed using "-Wl,-no_arch_warnings". Can be fixed by patching Externals/wxWidgets3/src/osx/core/bitmap.cpp to not compile the code that uses QuickTime; this code is already skipped on x86_64 and seems to provide support for an obsolete image format.
Updated by mthuurne over 12 years ago
I fixed the remaining issues and merged the branch into master.
Thanks to shuffle2 and glennrics for reviewing and to everyone else on IRC who helped along the way.
Updated by